paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

people: Don't refetch user when we already have it.

Browse Source
This commit is contained in:
evykassirer
2024-03-05 10:57:24 -08:00
committed by Tim Abbott
parent e965ed2eb8
commit af8263fb87
2 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/people.ts
View File

@@ -1234,17 +1234,11 @@ export function filter_people_by_search_terms(
// Loop through users and populate filtered_users only // Loop through users and populate filtered_users only
// if they include search_terms // if they include search_terms
for (const user of users) { for (const user of users) {
const person = get_by_email(user.email);
// Get person object (and ignore errors)
if (!person?.full_name) {
continue;
}
// Return user emails that include search terms // Return user emails that include search terms
const match = matchers.some((matcher) => matcher(user)); const match = matchers.some((matcher) => matcher(user));
if (match) { if (match) {
filtered_users.set(person.user_id, true); filtered_users.set(user.user_id, true);
} }
} }

7
web/tests/people.test.js
View File

@@ -758,13 +758,6 @@ test_people("filtered_users", () => {
filtered_people = people.filter_people_by_search_terms(users, ["ëm"]); filtered_people = people.filter_people_by_search_terms(users, ["ëm"]);
assert.equal(filtered_people.size, 1); assert.equal(filtered_people.size, 1);
assert.ok(filtered_people.has(noah.user_id)); assert.ok(filtered_people.has(noah.user_id));
// Test filtering with undefined user
users.push(invalid_user);
filtered_people = people.filter_people_by_search_terms(users, ["ltorv"]);
assert.equal(filtered_people.size, 1);
assert.ok(filtered_people.has(linus.user_id));
}); });
test_people("multi_user_methods", () => { test_people("multi_user_methods", () => {