paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Refactor the compose placeholder text function.

Browse Source 
This is a prep commit. Refactoring this makes it easier to reuse
these functions in other places without having to create the `opts`
object again.
This commit is contained in:
Vinit Singh
2020-07-27 19:37:38 +05:30
committed by Tim Abbott
parent a01d33353f
commit afa87156c6
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/compose.js
View File

@@ -1222,13 +1222,7 @@ exports.initialize = function () {
}); });
$("#compose-textarea").on("focus", () => { $("#compose-textarea").on("focus", () => {
const opts = { compose_actions.update_placeholder_text();
message_type: compose_state.get_message_type(),
stream: $("#stream_message_recipient_stream").val(),
topic: $("#stream_message_recipient_topic").val(),
private_message_recipient: compose_pm_pill.get_emails(),
};
compose_actions.update_placeholder_text(opts);
}); });
if (page_params.narrow !== undefined) { if (page_params.narrow !== undefined) {

14
static/js/compose_actions.js
View File

@@ -118,7 +118,7 @@ exports.complete_starting_tasks = function (msg_type, opts) {
compose_fade.start_compose(msg_type); compose_fade.start_compose(msg_type);
ui_util.decorate_stream_bar(opts.stream, $("#stream-message .message_header_stream"), true); ui_util.decorate_stream_bar(opts.stream, $("#stream-message .message_header_stream"), true);
$(document).trigger($.Event("compose_started.zulip", opts)); $(document).trigger($.Event("compose_started.zulip", opts));
exports.update_placeholder_text(opts); exports.update_placeholder_text();
}; };
exports.maybe_scroll_up_selected_message = function () { exports.maybe_scroll_up_selected_message = function () {
@@ -171,9 +171,15 @@ function same_recipient_as_before(msg_type, opts) {
); );
} }
exports.update_placeholder_text = function (opts) { exports.update_placeholder_text = function () {
const placeholder_text = compose_ui.compute_placeholder_text(opts); const opts = {
$("#compose-textarea").attr("placeholder", placeholder_text); message_type: compose_state.get_message_type(),
stream: $("#stream_message_recipient_stream").val(),
topic: $("#stream_message_recipient_topic").val(),
private_message_recipient: compose_pm_pill.get_emails(),
};
$("#compose-textarea").attr("placeholder", compose_ui.compute_placeholder_text(opts));
}; };
exports.start = function (msg_type, opts) { exports.start = function (msg_type, opts) {