banners: Redesign group info banner.

Fixes part of #34252.
This commit is contained in:
Maneesh Shukla
2025-07-30 18:58:08 +05:30
committed by Tim Abbott
parent 3651748d31
commit b0241bfa3c
3 changed files with 22 additions and 17 deletions

View File

@@ -7,7 +7,6 @@ import * as z from "zod/mini";
import render_confirm_delete_user from "../templates/confirm_dialog/confirm_delete_user.hbs"; import render_confirm_delete_user from "../templates/confirm_dialog/confirm_delete_user.hbs";
import render_confirm_join_group_direct_member from "../templates/confirm_dialog/confirm_join_group_direct_member.hbs"; import render_confirm_join_group_direct_member from "../templates/confirm_dialog/confirm_join_group_direct_member.hbs";
import render_modal_banner from "../templates/modal_banner/modal_banner.hbs"; import render_modal_banner from "../templates/modal_banner/modal_banner.hbs";
import render_group_info_banner from "../templates/modal_banner/user_group_info_banner.hbs";
import render_settings_checkbox from "../templates/settings/settings_checkbox.hbs"; import render_settings_checkbox from "../templates/settings/settings_checkbox.hbs";
import render_browse_user_groups_list_item from "../templates/user_group_settings/browse_user_groups_list_item.hbs"; import render_browse_user_groups_list_item from "../templates/user_group_settings/browse_user_groups_list_item.hbs";
import render_cannot_deactivate_group_banner from "../templates/user_group_settings/cannot_deactivate_group_banner.hbs"; import render_cannot_deactivate_group_banner from "../templates/user_group_settings/cannot_deactivate_group_banner.hbs";
@@ -19,6 +18,7 @@ import render_user_group_settings from "../templates/user_group_settings/user_gr
import render_user_group_settings_empty_notice from "../templates/user_group_settings/user_group_settings_empty_notice.hbs"; import render_user_group_settings_empty_notice from "../templates/user_group_settings/user_group_settings_empty_notice.hbs";
import render_user_group_settings_overlay from "../templates/user_group_settings/user_group_settings_overlay.hbs"; import render_user_group_settings_overlay from "../templates/user_group_settings/user_group_settings_overlay.hbs";
import type {Banner} from "./banners.ts";
import * as blueslip from "./blueslip.ts"; import * as blueslip from "./blueslip.ts";
import * as browser_history from "./browser_history.ts"; import * as browser_history from "./browser_history.ts";
import * as buttons from "./buttons.ts"; import * as buttons from "./buttons.ts";
@@ -85,6 +85,22 @@ const initial_group_filter = FILTERS.ACTIVE_GROUPS;
let group_list_widget: ListWidget.ListWidget<UserGroup, UserGroup>; let group_list_widget: ListWidget.ListWidget<UserGroup, UserGroup>;
let group_list_toggler: Toggle; let group_list_toggler: Toggle;
const GROUP_INFO_BANNER: Banner = {
intent: "info",
label: $t({
defaultMessage:
"User groups offer a flexible way to manage permissions in your organization.",
}),
buttons: [
{
label: $t({defaultMessage: "Learn more"}),
custom_classes: "banner-external-link",
attention: "quiet",
},
],
close_button: false,
};
function get_user_group_id(target: HTMLElement): number { function get_user_group_id(target: HTMLElement): number {
const $row = $(target).closest( const $row = $(target).closest(
".group-row, .user_group_settings_wrapper, .save-button, .group_settings_header", ".group-row, .user_group_settings_wrapper, .save-button, .group_settings_header",
@@ -1861,16 +1877,10 @@ export function setup_page(callback: () => void): void {
); );
$groups_overlay_container.html(groups_overlay_html); $groups_overlay_container.html(groups_overlay_html);
update_displayed_groups(initial_group_filter); update_displayed_groups(initial_group_filter);
const context = { settings_banner.set_up_banner(
banner_type: compose_banner.INFO, $(".group-info-banner"),
classname: "group_info", GROUP_INFO_BANNER,
hide_close_button: true, "/help/user-groups",
button_text: $t({defaultMessage: "Learn more"}),
button_link: "/help/user-groups",
};
$("#groups_overlay_container .nothing-selected .group-info-banner").html(
render_group_info_banner(context),
); );
settings_banner.set_up_upgrade_banners(); settings_banner.set_up_upgrade_banners();

View File

@@ -1,5 +0,0 @@
{{#> modal_banner . }}
<p class="banner_message">
{{#tr}}User groups offer a flexible way to manage permissions in your organization.{{/tr}}
</p>
{{/modal_banner}}

View File

@@ -48,7 +48,7 @@
</div> </div>
<div class="right"> <div class="right">
<div class="nothing-selected"> <div class="nothing-selected">
<div class="group-info-banner"></div> <div class="group-info-banner banner-wrapper"></div>
<div class="create-group-button-container"> <div class="create-group-button-container">
{{> ../settings/upgrade_tip_widget . }} {{> ../settings/upgrade_tip_widget . }}
<button type="button" class="create_user_group_button animated-purple-button">{{t 'Create user group' }}</button> <button type="button" class="create_user_group_button animated-purple-button">{{t 'Create user group' }}</button>