diff --git a/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py b/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py index 19db5ac9b1..37f8cbd7b5 100644 --- a/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py +++ b/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py @@ -44,9 +44,7 @@ class HelpDocumentationSpider(UnusedImagesLinterSpider): name = "help_documentation_crawler" start_urls = ['http://localhost:9981/help'] deny_domains = [] # type: List[str] - deny = ['/privacy', - # Ignored because scrapy seems to not process relatively URLs with ../ properly. - '[.][.]/'] + deny = ['/privacy'] images_path = "static/images/help" diff --git a/zerver/tests/test_docs.py b/zerver/tests/test_docs.py index e24a7d4fae..93943e33d8 100644 --- a/zerver/tests/test_docs.py +++ b/zerver/tests/test_docs.py @@ -128,7 +128,7 @@ class HelpTest(ZulipTestCase): def test_html_settings_links(self) -> None: result = self.client_get('/help/message-a-stream-by-email') self.assertEqual(result.status_code, 200) - self.assertIn('streams page', str(result.content)) + self.assertIn('streams page', str(result.content)) class IntegrationTest(TestCase): def test_check_if_every_integration_has_logo_that_exists(self) -> None: @@ -174,19 +174,19 @@ class IntegrationTest(TestCase): add_api_uri_context(context, HostRequestMock(host="mysubdomain.testserver")) self.assertEqual( context['settings_html'], - 'Zulip settings page') + 'Zulip settings page') self.assertEqual( context['subscriptions_html'], - 'streams page') + 'streams page') context = dict() add_api_uri_context(context, HostRequestMock()) self.assertEqual( context['settings_html'], - 'Zulip settings page') + 'Zulip settings page') self.assertEqual( context['subscriptions_html'], - 'streams page') + 'streams page') class AboutPageTest(ZulipTestCase): def setUp(self) -> None: diff --git a/zerver/views/integrations.py b/zerver/views/integrations.py index 37cf6294a1..e9d557714e 100644 --- a/zerver/views/integrations.py +++ b/zerver/views/integrations.py @@ -37,8 +37,8 @@ def add_api_uri_context(context: Dict[str, Any], request: HttpRequest) -> None: context["html_settings_links"] = html_settings_links if html_settings_links: - settings_html = 'Zulip settings page' - subscriptions_html = 'streams page' + settings_html = 'Zulip settings page' + subscriptions_html = 'streams page' else: settings_html = 'Zulip settings page' subscriptions_html = 'streams page'