paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

user groups: Implement General tab functionalities for group settings.

Browse Source 
There will be one more follow up commit to this, that will
add support for editing memberships of user groups and will
complete preliminary version for user group edit settings.

Follw up for #22214.
This commit is contained in:
Purushottam Tiwari
2022-09-03 01:02:34 +05:30
committed by Tim Abbott
parent 10a0bf4de4
commit b1c81e2e02
4 changed files with 109 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
static/js/user_group_edit.js
View File

@@ -1,15 +1,19 @@
import $ from "jquery";
import render_change_user_group_info_modal from "../templates/user_group_settings/change_user_group_info_modal.hbs";
import render_user_group_settings from "../templates/user_group_settings/user_group_settings.hbs";
import * as blueslip from "./blueslip";
import * as browser_history from "./browser_history";
import * as channel from "./channel";
import * as components from "./components";
import * as dialog_widget from "./dialog_widget";
import * as hash_util from "./hash_util";
import {$t} from "./i18n";
import {$t, $t_html} from "./i18n";
import {page_params} from "./page_params";
import * as people from "./people";
import * as settings_data from "./settings_data";
import * as settings_ui from "./settings_ui";
import * as ui from "./ui";
import * as user_group_ui_updates from "./user_group_ui_updates";
import * as user_groups from "./user_groups";
@@ -24,7 +28,7 @@ function setup_group_edit_hash(group) {
}
function get_user_group_id(target) {
const $row = $(target).closest(".group-row");
const $row = $(target).closest(".group-row, .user_group_settings_wrapper, .save-button");
return Number.parseInt($row.attr("data-group-id"), 10);
}
@@ -59,7 +63,9 @@ export function can_edit(group_id) {
}
export function get_edit_container(group) {
return $(`#groups_overlay .user_group_settings[data-group-id='${CSS.escape(group.id)}']`);
return $(
`#groups_overlay .user_group_settings_wrapper[data-group-id='${CSS.escape(group.id)}']`,
);
}
export function show_settings_for(node) {
@@ -76,7 +82,7 @@ export function show_settings_for(node) {
const $edit_container = get_edit_container(group);
$(".nothing-selected").hide();
$edit_container.addClass("show");
$edit_container.show();
}
export function setup_group_settings(node) {
@@ -112,4 +118,59 @@ export function initialize() {
open_group_edit_panel_for_row(this);
}
});
$("#manage_groups_container").on("click", "#open_group_info_modal", (e) => {
e.preventDefault();
e.stopPropagation();
const user_group_id = get_user_group_id(e.target);
const user_group = user_groups.get_user_group_from_id(user_group_id);
const template_data = {
group_name: user_group.name,
group_description: user_group.description,
};
const change_user_group_info_modal = render_change_user_group_info_modal(template_data);
dialog_widget.launch({
html_heading: $t_html(
{defaultMessage: "Edit {group_name}"},
{group_name: user_group.name},
),
html_body: change_user_group_info_modal,
id: "change_group_info_modal",
on_click: save_group_info,
post_render: () => {
$("#change_group_info_modal .dialog_submit_button")
.addClass("save-button")
.attr("data-group-id", user_group_id);
},
});
});
function save_group_info(e) {
e.preventDefault();
e.stopPropagation();
const group = get_user_group_for_target(e.currentTarget);
const url = `/json/user_groups/${group.id}`;
const data = {};
const new_name = $("#change_user_group_name").val().trim();
const new_description = $("#change_user_group_description").val().trim();
if (new_name === group.name && new_description === group.description) {
return;
}
if (new_name !== group.name) {
data.name = new_name;
} else {
data.name = group.name;
}
if (new_description !== group.description) {
data.description = new_description;
} else {
data.description = group.description;
}
const $status_element = $(".group_change_property_info");
dialog_widget.close_modal();
settings_ui.do_settings_change(channel.patch, url, data, $status_element);
}
}