paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

channels: Remove Add all users button from channel creation screen.

Browse Source
This commit is contained in:
Shubham Padia
2025-04-01 11:53:48 +00:00
committed by Tim Abbott
parent 81ba1bcb61
commit b2108404e7
4 changed files with 1 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/stream_create_subscribers.ts
View File

@@ -30,10 +30,6 @@ function add_user_ids(user_ids: number[]): void {
redraw_subscriber_list(); redraw_subscriber_list();
} }
function add_all_users(): void {
add_subscribers_pill.append_user_group_from_name("role:everyone", pill_widget!);
}
function soft_remove_user_id(user_id: number): void { function soft_remove_user_id(user_id: number): void {
stream_create_subscribers_data.soft_remove_user_id(user_id); stream_create_subscribers_data.soft_remove_user_id(user_id);
redraw_subscriber_list(); redraw_subscriber_list();
@@ -72,12 +68,6 @@ function build_pill_widget({
} }
export function create_handlers($container: JQuery): void { export function create_handlers($container: JQuery): void {
$container.on("click", ".add_all_users_to_stream", (e) => {
e.preventDefault();
add_all_users();
$(".add-user-list-filter").trigger("focus");
});
$container.on("click", ".remove_potential_subscriber", function (this: HTMLElement, e) { $container.on("click", ".remove_potential_subscriber", function (this: HTMLElement, e) {
e.preventDefault(); e.preventDefault();
const $subscriber_row = $(this).closest(".settings-subscriber-row"); const $subscriber_row = $(this).closest(".settings-subscriber-row");

15
web/src/stream_ui_updates.ts
View File

@@ -501,20 +501,7 @@ export function enable_or_disable_add_subscribers_elements(
$container_elem.find(".add_subscribers_container").addClass("add_subscribers_disabled"); $container_elem.find(".add_subscribers_container").addClass("add_subscribers_disabled");
} }
if (stream_creation) { if (!stream_creation) {
const $subscribe_all_users_button = $container_elem.find("button.add_all_users_to_stream");
$subscribe_all_users_button.prop("disabled", !enable_elem);
if (enable_elem) {
$container_elem
.find(".add_all_users_to_stream_button_container")
.removeClass("add_subscribers_disabled");
} else {
$container_elem
.find(".add_all_users_to_stream_button_container")
.addClass("add_subscribers_disabled");
}
} else {
const $add_subscribers_button = $container_elem.find(".add-subscriber-button").expectOne(); const $add_subscribers_button = $container_elem.find(".add-subscriber-button").expectOne();
$add_subscribers_button.prop("disabled", !enable_elem); $add_subscribers_button.prop("disabled", !enable_elem);
if (enable_elem) { if (enable_elem) {

6
web/styles/subscriptions.css
View File

@@ -971,12 +971,6 @@ h4.user_group_setting_subsection_title {
margin-left: 10px; margin-left: 10px;
} }
.add_all_users_to_stream {
margin-left: 10px;
/* same bottom margin as h4.stream_setting_subsection_title */
margin-bottom: 5px;
}
.create_user_group_member_list_header, .create_user_group_member_list_header,
.create_stream_subscriber_list_header { .create_stream_subscriber_list_header {
margin-top: 10px; margin-top: 10px;

8
web/templates/stream_settings/stream_creation_form.hbs
View File

@@ -36,14 +36,6 @@
<label class="choose-subscribers-label"> <label class="choose-subscribers-label">
<h4 class="stream_setting_subsection_title">{{t "Choose subscribers" }}</h4> <h4 class="stream_setting_subsection_title">{{t "Choose subscribers" }}</h4>
</label> </label>
<span class="add_all_users_to_stream_button_container">
{{> ../components/action_button
label=(t "Add all users")
custom_classes="add_all_users_to_stream inline-block"
attention="quiet"
intent="brand"
}}
</span>
<div id="stream_subscription_error" class="stream_creation_error"></div> <div id="stream_subscription_error" class="stream_creation_error"></div>
<div class="controls" id="people_to_add"></div> <div class="controls" id="people_to_add"></div>
</section> </section>