paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 08:56:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add and use util.is_current_user helper function.

Browse Source 
Previously, we were checking if a particular user was the current user
in dozens of places in the codebase, and correct case-insensitive
checks were not used consistently, leading to bugs like #502.
This commit is contained in:
Tim Abbott
2016-06-07 20:54:07 -07:00
parent 0bf2d171ae
commit b25562ca1d
13 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/activity.js
View File

@@ -371,7 +371,7 @@ function focus_ping() {
// Ping returns the active peer list
_.each(data.presences, function (presence, this_email) {
if (page_params.email !== this_email) {
if (!util.is_current_user(this_email)) {
exports.presence_info[this_email] = status_from_timestamp(data.server_timestamp, presence);
}
});
@@ -413,7 +413,7 @@ exports.set_user_statuses = function (users, server_time) {
var updated_users = {};
var status;
_.each(users, function (presence, email) {
if (email === page_params.email) {
if (util.is_current_user(email)) {
return;
}
status = status_from_timestamp(server_time, presence);