paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Verify info logs logging in test_fix_unreads.

Browse Source 
This commit verifies info logging in test_fix_unreads using assertLogs
so that the logging do not spam ./tools/test-backend output.
This commit is contained in:
Mohit Gupta
2020-07-20 03:31:05 +05:30
committed by Tim Abbott
parent 363cd8c099
commit b2745f6e41
1 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
zerver/tests/test_message_flags.py
View File

@@ -373,9 +373,21 @@ class FixUnreadTests(ZulipTestCase):
assert_unread(um_unsubscribed_id)
# fix unsubscribed
with connection.cursor() as cursor:
with connection.cursor() as cursor, \
self.assertLogs('zulip.fix_unreads', 'INFO') as info_logs:
fix_unsubscribed(cursor, user)
self.assertEqual(info_logs.output[0], 'INFO:zulip.fix_unreads:get recipients')
self.assertTrue('INFO:zulip.fix_unreads:[' in info_logs.output[1])
self.assertTrue('INFO:zulip.fix_unreads:elapsed time:' in info_logs.output[2])
self.assertEqual(info_logs.output[3],
'INFO:zulip.fix_unreads:finding unread messages for non-active streams')
self.assertEqual(info_logs.output[4], 'INFO:zulip.fix_unreads:rows found: 1')
self.assertTrue('INFO:zulip.fix_unreads:elapsed time:' in info_logs.output[5])
self.assertEqual(info_logs.output[6],
'INFO:zulip.fix_unreads:fixing unread messages for non-active streams')
self.assertTrue('INFO:zulip.fix_unreads:elapsed time:' in info_logs.output[7])
# Muted messages don't change.
assert_unread(um_muted_topic_id)
assert_unread(um_muted_stream_id)
@@ -384,8 +396,18 @@ class FixUnreadTests(ZulipTestCase):
# The unsubscribed entry should change.
assert_read(um_unsubscribed_id)
# test idempotency
fix(user)
with self.assertLogs('zulip.fix_unreads', 'INFO') as info_logs:
# test idempotency
fix(user)
self.assertEqual(info_logs.output[0], f'INFO:zulip.fix_unreads:\n---\nFixing {user.id}:')
self.assertEqual(info_logs.output[1], 'INFO:zulip.fix_unreads:get recipients')
self.assertTrue('INFO:zulip.fix_unreads:[' in info_logs.output[2])
self.assertTrue('INFO:zulip.fix_unreads:elapsed time:' in info_logs.output[3])
self.assertEqual(info_logs.output[4],
'INFO:zulip.fix_unreads:finding unread messages for non-active streams')
self.assertEqual(info_logs.output[5], 'INFO:zulip.fix_unreads:rows found: 0')
self.assertTrue('INFO:zulip.fix_unreads:elapsed time:' in info_logs.output[6])
assert_unread(um_normal_id)
assert_unread(um_muted_topic_id)