paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

portico: Remove container and row-fluild bootstrap classes.

Browse Source 
Fixes #28526

* Removed `container` and `row-fluid` class from error pages.
* Use a variable for footer height.
* Made header sticky instead of fixed allowing us to position
  page content without adding arbitrary padding or margin at top.
  Header is around 60px in height, so reduced that much top padding
  or margin.
This commit is contained in:
Aman Agrawal
2024-05-31 13:39:36 +00:00
committed by Tim Abbott
parent b3a5b2b9aa
commit b2f0677c25
4 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
templates/zerver/portico_error_page.html
View File

@@ -2,11 +2,7 @@
{% block portico_content %}
<div class="error_page">
<div class="container">
<div class="row-fluid">
{% block error_page_content %}
{% endblock %}
</div>
</div>
{% block error_page_content %}
{% endblock %}
</div>
{% endblock %}

16
web/html/5xx.html
View File

@@ -21,15 +21,13 @@
</div>
</div>
</div>
<div class="container">
<div class="row-fluid">
<img src="/static/images/errors/500art.svg" alt=""/>
<div class="errorbox">
<div class="errorcontent">
<h1 class="lead">Internal server error</h1>
<p>This Zulip server is currently experiencing some technical difficulties. Sorry about that!</p>
<p>The page will reload automatically soon after service is restored.</p>
</div>
<div class="error_page">
<img src="/static/images/errors/500art.svg" alt=""/>
<div class="errorbox">
<div class="errorcontent">
<h1 class="lead">Internal server error</h1>
<p>This Zulip server is currently experiencing some technical difficulties. Sorry about that!</p>
<p>The page will reload automatically soon after service is restored.</p>
</div>
</div>
</div>

7
web/styles/portico/portico.css
View File

@@ -1,5 +1,10 @@
:root {
--color-background-modal: hsl(0deg 0% 98%);
/*
It is fine if footer is longer than that
since we are only trying to avoid overlap.
*/
--height-footer: 495px;
}
[data-tippy-root] .tippy-box .tippy-content {
@@ -1010,7 +1015,7 @@ input.new-organization-button {
}
.error_page {
min-height: calc(100vh - 290px);
min-height: calc(100vh - var(--height-footer));
height: 100%;
background-color: hsl(163deg 42% 85%);
font-family: "Source Sans 3 VF", sans-serif;

6
web/styles/portico/portico_signin.css
View File

@@ -4,11 +4,11 @@ html {
.flex {
display: flex;
padding: 80px 0;
padding: 20px 0 80px;
align-items: center;
justify-content: center;
min-height: calc(100vh - 402px);
min-height: calc(100vh - var(--height-footer));
}
.m-10 {
@@ -292,7 +292,7 @@ html {
.header {
color: hsl(0deg 0% 27%);
background-color: hsl(0deg 0% 100%);
position: fixed;
position: sticky;
width: 100%;
top: 0;