paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 12:21:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

integrations: Remove Slack from WEBHOOK_SCREENSHOT_CONFIG.

Browse Source 
Slack integration requires Slack API key and will make API calls to
Slack. It'll also trip at `validate_account_and_subdomain` when
receiving Slack calls from a dev environemnt. So this commit removes it
from the tool.
This commit is contained in:
PieterCK
2025-10-02 17:27:15 +07:00
committed by Tim Abbott
parent 9d9fa71fdc
commit b37d6c7012
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/lib/integrations.py
View File

@@ -700,6 +700,8 @@ NO_SCREENSHOT_WEBHOOKS = (
{"beeminder"} {"beeminder"}
# Meta integrations - Docs won't have a screenshot # Meta integrations - Docs won't have a screenshot
| {"ifttt", "slack_incoming", "zapier"} | {"ifttt", "slack_incoming", "zapier"}
# Integrations that calls external API endpoints.
| {"slack"}
) )
hubot_integration_names = {integration.name for integration in HUBOT_INTEGRATIONS} hubot_integration_names = {integration.name for integration in HUBOT_INTEGRATIONS}
@@ -848,7 +850,6 @@ WEBHOOK_SCREENSHOT_CONFIG: dict[str, list[WebhookScreenshotConfig]] = {
"rundeck": [WebhookScreenshotConfig("start.json")], "rundeck": [WebhookScreenshotConfig("start.json")],
"semaphore": [WebhookScreenshotConfig("pull_request.json")], "semaphore": [WebhookScreenshotConfig("pull_request.json")],
"sentry": [WebhookScreenshotConfig("event_for_exception_python.json")], "sentry": [WebhookScreenshotConfig("event_for_exception_python.json")],
"slack": [WebhookScreenshotConfig("message_with_normal_text.json")],
"sonarqube": [WebhookScreenshotConfig("error.json")], "sonarqube": [WebhookScreenshotConfig("error.json")],
"sonarr": [WebhookScreenshotConfig("sonarr_episode_grabbed.json")], "sonarr": [WebhookScreenshotConfig("sonarr_episode_grabbed.json")],
"splunk": [WebhookScreenshotConfig("search_one_result.json")], "splunk": [WebhookScreenshotConfig("search_one_result.json")],