lint: Delegate console.log check to ESLint.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>

static/.eslintrc.json

@@ -0,0 +1,8 @@
+{
+    "env": {
+        "browser": true
+    },
+    "rules": {
+        "no-console": "error"
+    }
+}

static/js/.eslintrc.json

@@ -1,5 +0,0 @@
-{
-    "env": {
-        "browser": true
-    }
-}

static/js/blueslip.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+
 // System documented in https://zulip.readthedocs.io/en/latest/subsystems/logging.html
 
 // This must be included before the first call to $(document).ready

static/js/debug.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-console */
+
 /* WARNING:
 
     This file is only included when Django's DEBUG = True and your

tools/linter_lib/custom_check.py

@@ -156,13 +156,6 @@ js_rules = RuleList(
          'description': 'Write JS else statements on same line as }'},
         {'pattern': '^else if',
          'description': 'Write JS else statements on same line as }'},
-        {'pattern': 'console[.][a-z]',
-         'exclude': set(['static/js/blueslip.js',
-                         'frontend_tests/zjsunit',
-                         'frontend_tests/casper_lib/common.js',
-                         'frontend_tests/node_tests',
-                         'static/js/debug.js']),
-         'description': 'console.log and similar should not be used in webapp'},
         {'pattern': r'''[.]text\(["'][a-zA-Z]''',
          'description': 'Strings passed to $().text should be wrapped in i18n.t() for internationalization',
          'exclude': set(['frontend_tests/node_tests/'])},