paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

user avatar: Remove user_avatar_delete_button id.

Browse Source 
we can remove `user_avatar_delete_button` id and access delete button
from `#user-avatar-upload-widget .settings-page-delete-button` so that
we can have only one id at top level and 'image_upload_widget.hbs`
can be more dynamic so we can use for other similar widgets also.
This commit is contained in:
jagansivam28
2020-06-13 11:42:47 +05:30
committed by Tim Abbott
parent 95de217326
commit b3fca96254
5 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/settings_account.js
View File

@@ -68,17 +68,17 @@ exports.update_email_change_display = function () {
exports.update_avatar_change_display = function () {
if (!exports.user_can_change_avatar()) {
$('#user_avatar_upload_button .button').attr('disabled', 'disabled');
$('#user_avatar_delete_button .button').attr('disabled', 'disabled');
$("#user-avatar-upload-widget .settings-page-delete-button .button").attr('disabled', 'disabled');
} else {
$('#user_avatar_upload_button .button').attr('disabled', false);
$('#user_avatar_delete_button .button').attr('disabled', false);
$('#user-avatar-upload-widget .settings-page-delete-button .button').attr('disabled', false);
}
};
function display_avatar_upload_complete() {
$('#avatar-spinner-background').css({visibility: 'hidden'});
$('#user_avatar_upload_button').show();
$('#user_avatar_delete_button').show();
$('#user-avatar-upload-widget .settings-page-delete-button').show();
}
@@ -86,7 +86,7 @@ function display_avatar_upload_started() {
$("#user-avatar-source").hide();
$('#avatar-spinner-background').css({visibility: 'visible'});
$('#user_avatar_upload_button').hide();
$('#user_avatar_delete_button').hide();
$('#user-avatar-upload-widget .settings-page-delete-button').hide();
}