js: Convert static/js/gear_menu.js to ES6 module.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

.eslintrc.json

@@ -144,7 +144,6 @@
                 "emoji_picker": false,
                 "favicon": false,
                 "flatpickr": false,
-                "gear_menu": false,
                 "hash_util": false,
                 "hashchange": false,
                 "helpers": false,

frontend_tests/node_tests/hotkey.js

@@ -35,9 +35,12 @@ const emoji_picker = set_global("emoji_picker", {
 set_global("hotspots", {
     is_open: () => false,
 });
-const gear_menu = set_global("gear_menu", {
+const gear_menu = {
+    __esModule: true,
     is_open: () => false,
-});
+};
+
+rewiremock("../../static/js/gear_menu").with(gear_menu);
 
 // Important note on these tests:
 //

frontend_tests/node_tests/ui_init.js

@@ -72,7 +72,7 @@ rewiremock("../../static/js/click_handlers").with({initialize() {}});
 rewiremock("../../static/js/compose_pm_pill").with({initialize() {}});
 rewiremock("../../static/js/drafts").with({initialize() {}});
 set_global("emoji_picker", {initialize() {}});
-set_global("gear_menu", {initialize() {}});
+rewiremock("../../static/js/gear_menu").with({initialize() {}});
 set_global("hashchange", {initialize() {}});
 set_global("hotspots", {initialize() {}});
 // Accesses home_msg_list, which is a lot of complexity to set up

frontend_tests/node_tests/user_events.js

@@ -27,7 +27,7 @@ set_global("settings_users", {
     update_user_data() {},
 });
 
-set_global("gear_menu", {
+rewiremock("../../static/js/gear_menu").with({
     update_org_settings_menu_item() {},
 });
 const page_params = set_global("page_params", {

static/js/bundles/app.js

@@ -27,7 +27,6 @@ import "../reload";
 import "../compose_actions";
 import "../subs";
 import "../ui";
-import "../gear_menu";
 import "../stream_popover";
 import "../popovers";
 import "../overlays";

static/js/gear_menu.js

@@ -1,6 +1,4 @@
-"use strict";
+import * as message_viewport from "./message_viewport";
-
-const message_viewport = require("./message_viewport");
 
 /*
 For various historical reasons there isn't one
@@ -78,17 +76,17 @@ the selector and then calls hash_change.go_to_location.
 // when we switch back.)
 const scroll_positions = new Map();
 
-exports.update_org_settings_menu_item = function () {
+export function update_org_settings_menu_item() {
     const item = $(".admin-menu-item").expectOne();
     if (page_params.is_admin) {
         item.find("span").text(i18n.t("Manage organization"));
     } else {
         item.find("span").text(i18n.t("Organization settings"));
     }
-};
+}
 
-exports.initialize = function () {
+export function initialize() {
-    exports.update_org_settings_menu_item();
+    update_org_settings_menu_item();
 
     $('#gear-menu a[data-toggle="tab"]').on("show", (e) => {
         // Save the position of our old tab away, before we switch
@@ -121,22 +119,20 @@ exports.initialize = function () {
 
     // The admin and settings pages are generated client-side through
     // templates.
-};
+}
 
-exports.open = function () {
+export function open() {
     $("#settings-dropdown").trigger("click");
     // there are invisible li tabs, which should not be clicked.
     $("#gear-menu").find("li:not(.invisible) a").eq(0).trigger("focus");
-};
+}
 
-exports.is_open = function () {
+export function is_open() {
     return $(".dropdown").hasClass("open");
-};
+}
 
-exports.close = function () {
+export function close() {
-    if (exports.is_open()) {
+    if (is_open()) {
         $(".dropdown").removeClass("open");
     }
-};
+}
-
-window.gear_menu = exports;

static/js/global.d.ts

@@ -21,7 +21,6 @@ declare let current_msg_list: any;
 declare let emoji: any;
 declare let emoji_picker: any;
 declare let favicon: any;
-declare let gear_menu: any;
 declare let hashchange: any;
 declare let hash_util: any;
 declare let helpers: any;

static/js/hotkey.js

@@ -9,6 +9,7 @@ const condense = require("./condense");
 const copy_and_paste = require("./copy_and_paste");
 const drafts = require("./drafts");
 const feedback_widget = require("./feedback_widget");
+const gear_menu = require("./gear_menu");
 const lightbox = require("./lightbox");
 const message_edit = require("./message_edit");
 const muting_ui = require("./muting_ui");

static/js/ui_init.js

@@ -17,6 +17,7 @@ const copy_and_paste = require("./copy_and_paste");
 const drafts = require("./drafts");
 const echo = require("./echo");
 const emojisets = require("./emojisets");
+const gear_menu = require("./gear_menu");
 const invite = require("./invite");
 const lightbox = require("./lightbox");
 const markdown = require("./markdown");

static/js/user_events.js

@@ -5,6 +5,7 @@
 // dependencies that existed when this code was in people.js.
 // (We should do bot updates here too.)
 const compose = require("./compose");
+const gear_menu = require("./gear_menu");
 const message_live_update = require("./message_live_update");
 const narrow_state = require("./narrow_state");
 const people = require("./people");