paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Use do_change_user_role and do_set_realm_property.

Browse Source 
This commit replaces the code which directly changes user.role,
realm.create_stream_policy and realm.waiting_period_threshold
with do_change_user_role and do_set_realm_property functions
in test_can_create_streams. This makes the code similar to the
other tests.
This commit is contained in:
sahil839
2021-03-23 16:22:57 +05:30
committed by Tim Abbott
parent 683b6f7d65
commit b45d6ef0d8
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
zerver/tests/test_subs.py
View File

@@ -3204,34 +3204,34 @@ class SubscriptionAPITest(ZulipTestCase):
def test_can_create_streams(self) -> None: def test_can_create_streams(self) -> None:
othello = self.example_user("othello") othello = self.example_user("othello")
othello.role = UserProfile.ROLE_REALM_ADMINISTRATOR do_change_user_role(othello, UserProfile.ROLE_REALM_ADMINISTRATOR)
self.assertTrue(othello.can_create_streams()) self.assertTrue(othello.can_create_streams())
othello.role = UserProfile.ROLE_MEMBER do_change_user_role(othello, UserProfile.ROLE_MEMBER)
othello.realm.create_stream_policy = Realm.POLICY_ADMINS_ONLY do_set_realm_property(othello.realm, "create_stream_policy", Realm.POLICY_ADMINS_ONLY)
# Make sure that we are checking the permission with a full member, # Make sure that we are checking the permission with a full member,
# as full member is the user just below admin in the role hierarchy. # as full member is the user just below admin in the role hierarchy.
self.assertFalse(othello.is_provisional_member) self.assertFalse(othello.is_provisional_member)
self.assertFalse(othello.can_create_streams()) self.assertFalse(othello.can_create_streams())
othello.realm.create_stream_policy = Realm.POLICY_MEMBERS_ONLY do_set_realm_property(othello.realm, "create_stream_policy", Realm.POLICY_MEMBERS_ONLY)
othello.role = UserProfile.ROLE_GUEST do_change_user_role(othello, UserProfile.ROLE_GUEST)
self.assertFalse(othello.can_create_streams()) self.assertFalse(othello.can_create_streams())
othello.role = UserProfile.ROLE_MEMBER do_change_user_role(othello, UserProfile.ROLE_MEMBER)
self.assertTrue(othello.can_create_streams()) self.assertTrue(othello.can_create_streams())
othello.realm.waiting_period_threshold = 1000 do_set_realm_property(othello.realm, "waiting_period_threshold", 1000)
othello.realm.create_stream_policy = Realm.POLICY_FULL_MEMBERS_ONLY do_set_realm_property(othello.realm, "create_stream_policy", Realm.POLICY_FULL_MEMBERS_ONLY)
othello.date_joined = timezone_now() - timedelta( othello.date_joined = timezone_now() - timedelta(
days=(othello.realm.waiting_period_threshold - 1) days=(othello.realm.waiting_period_threshold - 1)
) )
self.assertFalse(othello.can_create_streams()) self.assertFalse(othello.can_create_streams())
othello.role = UserProfile.ROLE_MODERATOR do_change_user_role(othello, UserProfile.ROLE_MODERATOR)
self.assertTrue(othello.can_create_streams()) self.assertTrue(othello.can_create_streams())
othello.role = UserProfile.ROLE_MEMBER do_change_user_role(othello, UserProfile.ROLE_MEMBER)
othello.date_joined = timezone_now() - timedelta( othello.date_joined = timezone_now() - timedelta(
days=(othello.realm.waiting_period_threshold + 1) days=(othello.realm.waiting_period_threshold + 1)
) )