paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

navbar: Rename tab_bar to message_view_header.

Browse Source 
Prior to commit eb4a2b9d4e the center
area of the navbar was based on a structure that appended crumbs or
"tabs" as <li>s, forming a tab_bar and a tab_list.

However, in eb4a2b9d4e we apply a new
style and structure to the navbar which lets go of the convention of
tabs. Hence, we'd like to purge the tab_bar and tab_list labels from
our code base.

We purged tab_list in 1267caf5009118875f47fdafe312880af08024e1.

This commit purges tab_bar, it includes:
- A blanket search and replace of tab_bar with message_view_header.
- Splitting a single line comment in
  tab_bar.js / message_view_header.js.
- The renaming of tab_bar.js to message_view_header.js.
- The renaming of tab_bar.hbs to message_view_header.hbs.
- A blanket search and replace of tab_data with
  message_view_header_data.
- Replacing the single occurrence of tabbar with message_view_header
  (it was within a comment.)
This commit is contained in:
YashRE42
2020-07-08 21:44:01 +00:00
committed by Tim Abbott
parent a68d38cc52
commit b4891a5841
24 changed files with 100 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/search.js
View File

@@ -108,7 +108,7 @@ exports.initialize = function () {
},
// Use our custom typeahead `on_escape` hook to exit
// the search bar as soon as the user hits Esc.
on_escape: tab_bar.exit_search,
on_escape: message_view_header.exit_search,
});
searchbox_form.on("compositionend", () => {
@@ -195,7 +195,7 @@ exports.initialize = function () {
// while we want to add box-shadow to `#searchbox`. This could have been done
// with `:focus-within` CSS selector, but it is not supported in IE or Opera.
searchbox.on("focusout", () => {
tab_bar.close_search_bar_and_open_narrow_description();
message_view_header.close_search_bar_and_open_narrow_description();
searchbox.css({"box-shadow": "unset"});
});
}
@@ -207,7 +207,7 @@ exports.focus_search = function () {
};
exports.initiate_search = function () {
tab_bar.open_search_bar_and_close_narrow_description();
message_view_header.open_search_bar_and_close_narrow_description();
$("#searchbox").css({"box-shadow": "inset 0px 0px 0px 2px hsl(204, 20%, 74%)"});
$("#search_query").typeahead("lookup").trigger("select");
if (page_params.search_pills_enabled) {