paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 03:11:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

notifications: Add support for None option in Notification sound.

Browse Source 
This commit adds support for a `None` option in the dropdown menu
of `Notification sound`. When this option is selected, no audible
notification is sent to the user.

`None` will appear as the first option in the dropdown menu, since
this is not categorized as a playable audio.

This new option is added so that folks can disable audio notifications
without losing their other notification configuration (like for PMs, mentions).

Necessary test case is added for this new option.

Fixes #16090.
This commit is contained in:
akshatdalton
2021-04-27 23:04:06 +00:00
committed by Tim Abbott
parent 8e2042d378
commit b573964bfa
5 changed files with 42 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
static/js/notifications.js
View File

@@ -91,14 +91,16 @@ export function initialize() {
}
function update_notification_sound_source() {
const audio_file_without_extension =
"/static/audio/notification_sounds/" + page_params.notification_sound;
const notification_sound = page_params.notification_sound;
const audio_file_without_extension = "/static/audio/notification_sounds/" + notification_sound;
$("#notification-sound-source-ogg").attr("src", `${audio_file_without_extension}.ogg`);
$("#notification-sound-source-mp3").attr("src", `${audio_file_without_extension}.mp3`);
// Load it so that it is ready to be played; without this the old sound
// is played.
$("#notification-sound-audio")[0].load();
if (notification_sound !== "none") {
// Load it so that it is ready to be played; without this the old sound
// is played.
$("#notification-sound-audio")[0].load();
}
}
export function permission_state() {
@@ -415,6 +417,12 @@ export function should_send_desktop_notification(message) {
}
export function should_send_audible_notification(message) {
// If `None` is selected as the notification sound, never send
// audible notifications regardless of other configuration.
if (page_params.notification_sound === "none") {
return false;
}
// For streams, ding if sounds are enabled for all messages on
// this stream.
if (