paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

todo widget: Rename function to name_in_use().

Browse Source 
The name here is a bit more precise, as we're
not checking whether a task exists so much
as whether just a particular name is in use.

We also move the function out of the `check_task`
layer, which feels a bit overkill in terms
of nesting (plus, we're gonna remove the other
function inside of `check_task` soon).
This commit is contained in:
Steve Howell
2020-04-08 17:41:28 +00:00
committed by showell
parent 4eafaf1302
commit b5e6d872e6
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
static/js/todo_widget.js
View File

@@ -29,12 +29,13 @@ exports.task_data_holder = function () {
return widget_data;
};
self.check_task = {
task_exists: function (task) {
const task_exists = all_tasks.some(item => item.task === task);
return task_exists;
},
self.name_in_use = function (name) {
const task_exists = all_tasks.some(item => item.task === name);
return task_exists;
};
self.check_task = {
get_task_index: function (list, val) {
return Object.keys(list).find(index => list[index].key === val);
},
@@ -52,7 +53,7 @@ exports.task_data_holder = function () {
};
my_idx += 1;
if (!self.check_task.task_exists(task)) {
if (!self.name_in_use(task)) {
return event;
}
return;
@@ -73,7 +74,7 @@ exports.task_data_holder = function () {
completed: completed,
};
if (!self.check_task.task_exists(task)) {
if (!self.name_in_use(task)) {
all_tasks.push(task_data);
if (my_idx <= idx) {
@@ -142,7 +143,7 @@ exports.activate = function (opts) {
elem.find(".add-task").val('').focus();
elem.find(".add-desc").val('').focus();
const task_exists = task_data.check_task.task_exists(task);
const task_exists = task_data.name_in_use(task);
if (task_exists) {
elem.find(".widget-error").text(i18n.t('Task already exists'));
return;