mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	minify-js: Fix failure to update JS files on Git deploys.
This fixes a significant static asset pipeline bug, which mean that when we added `moment.js` to the Zulip npm dependencies, it wasn't properly included in common.js; caching prevented common.js from ever being rebuilt.
This commit is contained in:
		@@ -61,6 +61,10 @@ def get_changed_source_files(other_checkout):
 | 
			
		||||
 | 
			
		||||
    changed = set() # type: Set[str]
 | 
			
		||||
    for filename in git_diff.split('\n'):
 | 
			
		||||
        if filename in ["package.json", "zproject/settings.py", "tools/minify-js",
 | 
			
		||||
                        "tools/tools/webpack.production.config.js"]:
 | 
			
		||||
            print("Changed a core JS pipeline file; not reusing cached minification results")
 | 
			
		||||
            return None
 | 
			
		||||
        if not filename.startswith(STATIC_PATH):
 | 
			
		||||
            continue  # Ignore non-static files.
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user