paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

spectators: Prevent toggling TODO checkboxes.

Browse Source 
Checkboxes now don't change if a user who is not logged in
clicks on them.

Fixes #20300.
This commit is contained in:
Julia Bichler
2021-12-22 15:56:11 +01:00
committed by Tim Abbott
parent b0b8f84949
commit b673e966ca
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/todo_widget.js
View File

@@ -5,6 +5,7 @@ import render_widgets_todo_widget_tasks from "../templates/widgets/todo_widget_t
import * as blueslip from "./blueslip";
import {$t} from "./i18n";
import {page_params} from "./page_params";
import * as util from "./util";
// Any single user should send add a finite number of tasks
@@ -193,6 +194,17 @@ export function activate(opts) {
elem.find("input.task").on("click", (e) => {
e.stopPropagation();
if (page_params.is_spectator) {
// Logically, spectators should not be able totoggle
// TODO checkboxes. However, the browser changes the
// checkbox's state before calling handlers like this,
// so we need to just toggle the checkbox back to its
// previous state.
$(e.target).prop("checked", !$(e.target).is(":checked"));
$(e.target).blur();
return;
}
const key = $(e.target).attr("data-key");
const data = task_data.handle.strike.outbound(key);