From b69e85fa05858dc9cc943e958d2703cbfbb10254 Mon Sep 17 00:00:00 2001 From: Harshit Bansal Date: Fri, 29 Sep 2017 20:16:36 +0000 Subject: [PATCH] emoji_picker: Don't display title text for emojis in emoji picker. Now that we display the name and aliases of the currently focused emoji at the bottom of the emoji picker, we don't need to display the title text for emojis separately. Fixes: #6111. --- frontend_tests/node_tests/templates.js | 4 ++-- static/templates/emoji_popover_emoji.handlebars | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend_tests/node_tests/templates.js b/frontend_tests/node_tests/templates.js index 2a79d2cebc..0059023c7f 100644 --- a/frontend_tests/node_tests/templates.js +++ b/frontend_tests/node_tests/templates.js @@ -600,8 +600,8 @@ function render(template_name, args) { html += render('emoji_popover_content', args); html += ""; // test to make sure the first emoji is present in the popover - var emoji_key = $(html).find(".emoji-100").attr('title'); - assert.equal(emoji_key, '100'); + var first_emoji = $(html).find(".emoji-100"); + assert.equal(first_emoji.length, 1); var categories = $(html).find(".emoji-popover-tab-item"); assert.equal(categories.length, 2); diff --git a/static/templates/emoji_popover_emoji.handlebars b/static/templates/emoji_popover_emoji.handlebars index 5d4d3c0d6c..c766bb38ed 100644 --- a/static/templates/emoji_popover_emoji.handlebars +++ b/static/templates/emoji_popover_emoji.handlebars @@ -1,9 +1,9 @@ {{#with emoji_dict}}
{{#if is_realm_emoji}} - + {{else}} -
+
{{/if}}
{{/with}}