paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_queue_worker: Fix order-dependent assertions.

Browse Source
This commit is contained in:
Tim Abbott
2021-07-06 14:37:16 -07:00
parent 4db187856d
commit b6afa4a82b
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
zerver/tests/test_queue_worker.py
View File

@@ -623,17 +623,13 @@ class WorkerTest(ZulipTestCase):
def test_get_active_worker_queues(self) -> None: def test_get_active_worker_queues(self) -> None:
test_queue_names = set(get_active_worker_queues(only_test_queues=True)) test_queue_names = set(get_active_worker_queues(only_test_queues=True))
# Actually 6, but test_timeouts, which defines TimeoutWorker,
# is called after this
self.assertEqual(5, len(test_queue_names))
# This misses that TestWorker, defined in test_worker_noname
# with no assign_queue, because it runs after this
worker_queue_names = { worker_queue_names = {
queue_class.queue_name queue_class.queue_name
for base in [QueueProcessingWorker, EmailSendingWorker, LoopQueueProcessingWorker] for base in [QueueProcessingWorker, EmailSendingWorker, LoopQueueProcessingWorker]
for queue_class in base.__subclasses__() for queue_class in base.__subclasses__()
if not isabstract(queue_class) if not isabstract(queue_class)
} }
# Verify that the set of active worker queues equals the set
# of of subclasses without is_test_queue set.
self.assertEqual(set(get_active_worker_queues()), worker_queue_names - test_queue_names) self.assertEqual(set(get_active_worker_queues()), worker_queue_names - test_queue_names)