From b7127a395b94e50440a55ad970e796e23d51d74d Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Tue, 11 Dec 2018 11:29:25 -0800 Subject: [PATCH] server_settings: Use a reasonable default when User-Agent not specified. Apparently, some Zulip clients don't send a User-Agent in their requests to /server_settings, and this makes that not 500. --- zerver/views/auth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/views/auth.py b/zerver/views/auth.py index 7e3a7d258b..66caf098ca 100644 --- a/zerver/views/auth.py +++ b/zerver/views/auth.py @@ -845,7 +845,7 @@ def api_get_auth_backends(request: HttpRequest) -> HttpResponse: return json_success(auth_backends) def check_server_incompatibility(request: HttpRequest) -> bool: - user_agent = parse_user_agent(request.META["HTTP_USER_AGENT"]) + user_agent = parse_user_agent(request.META.get("HTTP_USER_AGENT", "Missing User-Agent")) return user_agent['name'] == "ZulipInvalid" @require_GET