paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

reactions: Don't create local echo for reactions at a common point.

Browse Source 
update_ui_and_send_reaction_ajax is called from hotkeys, popovers,
reaction clicks, etc. but it is the common point to deny
spectator from creating a reaction local echo.
This commit is contained in:
Aman Agrawal
2021-11-21 16:31:12 +00:00
committed by Tim Abbott
parent d3a47b3a83
commit b72a9c1261
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
static/js/reactions.js
View File

@@ -66,6 +66,13 @@ function create_reaction(message_id, reaction_info) {
}
function update_ui_and_send_reaction_ajax(message_id, reaction_info) {
if (page_params.is_spectator) {
// Spectators can't react, since they don't have accounts. We
// stop here to avoid a confusing reaction local echo.
spectators.login_to_access();
return;
}
const message = get_message(message_id);
const local_id = get_local_reaction_id(reaction_info);
const has_reacted = current_user_has_reacted_to_emoji(message, local_id);
@@ -111,13 +118,6 @@ export function toggle_emoji_reaction(message_id, emoji_name) {
}
export function process_reaction_click(message_id, local_id) {
if (page_params.is_spectator) {
// Spectators can't react, since they don't have accounts. We
// stop here to avoid a confusing reaction local echo.
spectators.login_to_access();
return;
}
const message = get_message(message_id);
if (!message) {