paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_bots.py: Split up test_create_embedded_bot.

Browse Source
This commit is contained in:
Robert Hönig
2018-02-25 13:09:44 -05:00
committed by Steve Howell
parent a99cc6170f
commit b780b16f57
1 changed files with 27 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
zerver/tests/test_bots.py
View File

@@ -1132,25 +1132,24 @@ class BotTest(ZulipTestCase, UploadSerializeMixin):
result = self.client_post("/json/bots", bot_info) result = self.client_post("/json/bots", bot_info)
self.assert_json_success(result) self.assert_json_success(result)
def test_create_embedded_bot(self, **extras: Any) -> None: def test_create_embedded_bot_with_disabled_embedded_bots(self, **extras: Any) -> None:
user_profile = self.example_user("hamlet")
bot_config_info = {'key': 'value'}
bot_info = {
'full_name': 'Embedded test bot',
'bot_type': UserProfile.EMBEDDED_BOT,
'service_name': 'followup',
'config_data': ujson.dumps(bot_config_info),
}
bot_info.update(extras)
# Test to create embedded bot with correct service_name and disabled embedded bots.
with self.settings(EMBEDDED_BOTS_ENABLED=False): with self.settings(EMBEDDED_BOTS_ENABLED=False):
self.create_test_bot(short_name='embeddedservicebot', user_profile=user_profile, self.create_test_bot(short_name='embeddedservicebot',
user_profile=self.example_user("hamlet"),
bot_type=UserProfile.EMBEDDED_BOT,
service_name='followup',
config_data=ujson.dumps({'key': 'value'}),
assert_json_error_msg='Embedded bots are not enabled.', assert_json_error_msg='Embedded bots are not enabled.',
**bot_info) **extras)
# Test to create embedded bot with correct service_name and enabled embedded bots.
self.create_test_bot(short_name='embeddedservicebot', **bot_info, user_profile=user_profile)
def test_create_embedded_bot(self, **extras: Any) -> None:
bot_config_info = {'key': 'value'}
self.create_test_bot(short_name='embeddedservicebot',
user_profile=self.example_user("hamlet"),
bot_type=UserProfile.EMBEDDED_BOT,
service_name='followup',
config_data=ujson.dumps(bot_config_info),
**extras)
bot_email = "embeddedservicebot-bot@zulip.testserver" bot_email = "embeddedservicebot-bot@zulip.testserver"
bot_realm = get_realm('zulip') bot_realm = get_realm('zulip')
bot = get_user(bot_email, bot_realm) bot = get_user(bot_email, bot_realm)
@@ -1162,19 +1161,21 @@ class BotTest(ZulipTestCase, UploadSerializeMixin):
self.assertEqual(service.name, "followup") self.assertEqual(service.name, "followup")
self.assertEqual(service.user_profile, bot) self.assertEqual(service.user_profile, bot)
# Test to create embedded bot with incorrect service_name def test_create_embedded_bot_with_incorrect_service_name(self, **extras: Any) -> None:
bot_info.update({'service_name': 'not_existing_service'}) self.create_test_bot(short_name='embeddedservicebot',
self.create_test_bot(short_name='embeddedservicebot', user_profile=user_profile, user_profile=self.example_user("hamlet"),
bot_type=UserProfile.EMBEDDED_BOT,
service_name='not_existing_service',
assert_json_error_msg='Invalid embedded bot name.', assert_json_error_msg='Invalid embedded bot name.',
**bot_info) **extras)
# Test to create embedded bot with an invalid config value def test_create_embedded_bot_with_invalid_config_value(self, **extras: Any) -> None:
malformatted_bot_config_info = {'foo': ['bar', 'baz']} self.create_test_bot(short_name='embeddedservicebot',
bot_info.update({'service_name': 'followup', user_profile=self.example_user("hamlet"),
'config_data': ujson.dumps(malformatted_bot_config_info)}) service_name='followup',
self.create_test_bot(short_name='embeddedservicebot', user_profile=user_profile, config_data=ujson.dumps({'invalid': ['config', 'value']}),
assert_json_error_msg='config_data contains a value that is not a string', assert_json_error_msg='config_data contains a value that is not a string',
**bot_info) **extras)
def test_is_cross_realm_bot_email(self) -> None: def test_is_cross_realm_bot_email(self) -> None:
self.assertTrue(is_cross_realm_bot_email("notification-bot@zulip.com")) self.assertTrue(is_cross_realm_bot_email("notification-bot@zulip.com"))