From b829b95108fe4bdbc120eb0466b5fefb80a888d0 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Thu, 13 May 2021 11:13:27 -0700 Subject: [PATCH] email_mirror: Remove unnecessary EMAIL_GATEWAY_PATTERN logging. These logs were pretty spammy, and there have long been much better ways to communicate to system administrators that the incoming email gateway is great, including, most importantly, in the section of the emails themselves that explains how replying works. --- zerver/lib/email_mirror.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/zerver/lib/email_mirror.py b/zerver/lib/email_mirror.py index 2a645a8152..bc51a69559 100644 --- a/zerver/lib/email_mirror.py +++ b/zerver/lib/email_mirror.py @@ -155,11 +155,10 @@ def get_usable_missed_message_address(address: str) -> MissedMessageEmailAddress def create_missed_message_address(user_profile: UserProfile, message: Message) -> str: + # If the email gateway isn't configured, we specify a reply + # address, since there's no useful way for the user to reply into + # Zulip. if settings.EMAIL_GATEWAY_PATTERN == "": - logger.warning( - "EMAIL_GATEWAY_PATTERN is an empty string, using " - "NOREPLY_EMAIL_ADDRESS in the 'from' field." - ) return FromAddress.NOREPLY mm_address = MissedMessageEmailAddress.objects.create(