paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

copy_messages: Prevent blueslip error while copying overlay message header.

Browse Source 
Fixes: https://github.com/zulip/zulip/pull/35097#issuecomment-3058834909
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
This commit is contained in:
apoorvapendse
2025-07-11 14:06:23 +05:30
committed by Tim Abbott
parent 183b79b1ab
commit b8a1a224d5
4 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/copy_messages.ts
View File

@@ -328,7 +328,10 @@ export function analyze_selection(selection: Selection): {
$startc = $(range.startContainer);
start_data = find_boundary_tr(
$startc.parents(".selectable_row, .message_header").first(),
$startc
.parents(".selectable_row, .message_header")
.not(".overlay-message-header")
.first(),
($row) => $row.next(),
);
if (start_data === undefined) {

4
web/templates/draft.hbs
View File

@@ -1,7 +1,7 @@
<div class="draft-message-row overlay-message-row" data-draft-id="{{draft_id}}">
<div class="draft-message-info-box overlay-message-info-box" tabindex="0">
{{#if is_stream}}
<div class="message_header message_header_stream restore-overlay-message">
<div class="message_header message_header_stream restore-overlay-message overlay-message-header">
<div class="message-header-contents" style="background: {{recipient_bar_color}};">
<div class="message_label_clickable stream_label">
<span class="stream-privacy-modified-color-{{stream_id}} stream-privacy filter-icon" style="color: {{stream_privacy_icon_color}}">
@@ -24,7 +24,7 @@
</div>
</div>
{{else}}
<div class="message_header message_header_private_message restore-overlay-message">
<div class="message_header message_header_private_message restore-overlay-message overlay-message-header">
<div class="message-header-contents">
<div class="message_label_clickable stream_label">
<span class="private_message_header_icon"><i class="zulip-icon zulip-icon-user"></i></span>

2
web/templates/reminder_list.hbs
View File

@@ -1,7 +1,7 @@
{{#each reminders_data}}
<div class="reminder-row overlay-message-row" data-reminder-id="{{reminder_id}}">
<div class="reminder-info-box overlay-message-info-box" tabindex="0">
<div class="message_header message_header_private_message">
<div class="message_header message_header_private_message overlay-message-header">
<div class="message-header-contents">
<div class="message_label_clickable stream_label">
<span class="private_message_header_icon"><i class="zulip-icon zulip-icon-user"></i></span>

4
web/templates/scheduled_message.hbs
View File

@@ -2,7 +2,7 @@
<div class="scheduled-message-row overlay-message-row" data-scheduled-message-id="{{scheduled_message_id}}">
<div class="scheduled-message-info-box overlay-message-info-box" tabindex="0">
{{#if is_stream}}
<div class="message_header message_header_stream restore-overlay-message">
<div class="message_header message_header_stream restore-overlay-message overlay-message-header">
<div class="message-header-contents" style="background: {{recipient_bar_color}};">
<div class="message_label_clickable stream_label">
<span class="stream-privacy-modified-color-{{stream_id}} stream-privacy filter-icon" style="color: {{stream_privacy_icon_color}}">
@@ -21,7 +21,7 @@
</div>
</div>
{{else}}
<div class="message_header message_header_private_message restore-overlay-message">
<div class="message_header message_header_private_message restore-overlay-message overlay-message-header">
<div class="message-header-contents">
<div class="message_label_clickable stream_label">
<span class="private_message_header_icon"><i class="zulip-icon zulip-icon-user"></i></span>