paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

users: Return true for admins for is_moderator.

Browse Source 
This change is for consistency with how is_admin works.

API design discussion at https://chat.zulip.org/#narrow/channel/378-api-design/topic/Should.20is_moderator.20have.20admins
This commit is contained in:
Shubham Padia
2025-04-17 12:43:07 +00:00
committed by Tim Abbott
parent 50fbaa4da6
commit b8ba174455
18 changed files with 58 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/tests/message_edit.test.cjs
View File

@@ -95,7 +95,7 @@ run_test("is_topic_editable", ({override}) => {
};
override(realm, "realm_allow_message_editing", true);
override(settings_data, "user_can_move_messages_to_another_topic", () => true);
override(current_user, "is_admin", true);
override(current_user, "is_moderator", true);
assert.equal(message_edit.is_topic_editable(message), false);
@@ -112,7 +112,7 @@ run_test("is_topic_editable", ({override}) => {
override(settings_data, "user_can_move_messages_to_another_topic", () => false);
assert.equal(message_edit.is_topic_editable(message), false);
override(current_user, "is_admin", false);
override(current_user, "is_moderator", false);
assert.equal(message_edit.is_topic_editable(message), false);
message.topic = "translated: (no topic)";
@@ -149,7 +149,7 @@ run_test("is_stream_editable", ({override}) => {
};
override(realm, "realm_allow_message_editing", true);
override(settings_data, "user_can_move_messages_between_streams", () => true);
override(current_user, "is_admin", true);
override(current_user, "is_moderator", true);
assert.equal(message_edit.is_stream_editable(message), false);
@@ -166,7 +166,7 @@ run_test("is_stream_editable", ({override}) => {
override(settings_data, "user_can_move_messages_between_streams", () => false);
assert.equal(message_edit.is_stream_editable(message), false);
override(current_user, "is_admin", false);
override(current_user, "is_moderator", false);
assert.equal(message_edit.is_stream_editable(message), false);
override(realm, "realm_move_messages_between_streams_limit_seconds", 259200);