paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

node_tests: Extend unread.test.js to catch private message mentions bug.

Browse Source 
In the "mentions" test, an additional unread message with the type
"private" and directly mentioning me has been added. This test case
checks for the scenario when the stream_id is null during the
reverse_lookup, which would have caused the test to fail before the
bug fix was implemented which now passes after the fix is applied.
This commit is contained in:
Hardik Dharmani
2023-05-05 19:58:06 +05:30
committed by Tim Abbott
parent b063779800
commit b9611489ca
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
web/tests/unread.test.js
View File

@@ -24,7 +24,14 @@ const me = {
user_id: 30, user_id: 30,
full_name: "Me Myself", full_name: "Me Myself",
}; };
const anybody = {
email: "anybody@example.com",
user_id: 999,
full_name: "Any Body",
};
people.add_active_user(me); people.add_active_user(me);
people.add_active_user(anybody);
people.initialize_current_user(me.user_id); people.initialize_current_user(me.user_id);
const social = { const social = {
@@ -382,13 +389,6 @@ test("private_messages", () => {
let counts = unread.get_counts(); let counts = unread.get_counts();
assert.equal(counts.private_message_count, 0); assert.equal(counts.private_message_count, 0);
const anybody = {
email: "anybody@example.com",
user_id: 999,
full_name: "Any Body",
};
people.add_active_user(anybody);
const message = { const message = {
id: 15, id: 15,
type: "private", type: "private",
@@ -527,32 +527,45 @@ test("mentions", () => {
unread: true, unread: true,
}; };
const private_mention_me_message = {
id: 19,
type: "private",
display_recipient: [{id: anybody.user_id}],
mentioned: true,
mentioned_me_directly: true,
unread: true,
};
unread.process_loaded_messages([ unread.process_loaded_messages([
already_read_message, already_read_message,
mention_me_message, mention_me_message,
mention_all_message, mention_all_message,
muted_mention_all_message, muted_mention_all_message,
muted_direct_mention_message, muted_direct_mention_message,
private_mention_me_message,
]); ]);
counts = unread.get_counts(); counts = unread.get_counts();
assert.equal(counts.mentioned_message_count, 3); assert.equal(counts.mentioned_message_count, 4);
assert.deepEqual(unread.get_msg_ids_for_mentions(), [ assert.deepEqual(unread.get_msg_ids_for_mentions(), [
mention_me_message.id, mention_me_message.id,
mention_all_message.id, mention_all_message.id,
muted_direct_mention_message.id, muted_direct_mention_message.id,
private_mention_me_message.id,
]); ]);
assert.deepEqual(unread.get_all_msg_ids(), [ assert.deepEqual(unread.get_all_msg_ids(), [
mention_me_message.id, mention_me_message.id,
mention_all_message.id, mention_all_message.id,
muted_mention_all_message.id, muted_mention_all_message.id,
muted_direct_mention_message.id, muted_direct_mention_message.id,
private_mention_me_message.id,
]); ]);
test_notifiable_count(counts.home_unread_messages, 3); test_notifiable_count(counts.home_unread_messages, 5);
unread.mark_as_read(mention_me_message.id); unread.mark_as_read(mention_me_message.id);
unread.mark_as_read(mention_all_message.id); unread.mark_as_read(mention_all_message.id);
unread.mark_as_read(muted_direct_mention_message.id); unread.mark_as_read(muted_direct_mention_message.id);
unread.mark_as_read(private_mention_me_message.id);
counts = unread.get_counts(); counts = unread.get_counts();
assert.equal(counts.mentioned_message_count, 0); assert.equal(counts.mentioned_message_count, 0);
test_notifiable_count(counts.home_unread_messages, 0); test_notifiable_count(counts.home_unread_messages, 0);