paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_fade: Use stream id to get sub objects.

Browse Source 
This commit changes would_receive_message and want_normal_display
functions in compose_fade.js to use stream id, instead of stream
name, to get sub object. We are using stream ids so that we can
avoid bugs related to live update after stream rename.
This commit is contained in:
sahil839
2020-06-21 03:08:59 +05:30
committed by Tim Abbott
parent b7f6a51797
commit b99320ffa0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/compose_fade.js
View File

@@ -94,7 +94,7 @@ function fade_messages() {
exports.would_receive_message = function (user_id) {
if (focused_recipient.type === 'stream') {
const sub = stream_data.get_sub(focused_recipient.stream);
const sub = stream_data.get_sub_by_id(focused_recipient.stream_id);
if (!sub) {
// If the stream isn't valid, there is no risk of a mix
// yet, so we sort of "lie" and say they would receive a
@@ -154,7 +154,7 @@ function want_normal_display() {
if (focused_recipient.type === "stream") {
// If a stream doesn't exist, there is no real chance of a mix, so fading
// is just noise to the user.
if (!stream_data.get_sub(focused_recipient.stream)) {
if (!stream_data.get_sub_by_id(focused_recipient.stream_id)) {
return true;
}