node tests: Just set i18n every time.

Explicitly stubbing i18n in 48 different files
is mostly busy work at this point, and it doesn't
provide much signal, since often it's invoked
only to satisfy transitive dependencies.

frontend_tests/node_tests/activity.js

@@ -54,7 +54,6 @@ const _resize = {
     resize_page_components: () => {},
 };
 
-set_global('i18n', global.stub_i18n);
 set_global('padded_widget', {
     update_padding: () => {},
 });

frontend_tests/node_tests/alert_words_ui.js

@@ -1,5 +1,4 @@
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 
 set_global('channel', {});
 

frontend_tests/node_tests/buddy_data.js

@@ -3,7 +3,6 @@ const _page_params = {};
 set_global('blueslip', global.make_zblueslip());
 
 set_global('page_params', _page_params);
-set_global('i18n', global.stub_i18n);
 set_global('$', global.make_zjquery());
 zrequire('people');
 zrequire('presence');

frontend_tests/node_tests/components.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('keydown_util');
 zrequire('components');

frontend_tests/node_tests/compose.js

@@ -5,7 +5,6 @@ set_global('blueslip', global.make_zblueslip());
 const noop = function () {};
 
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 
 const LazySet = zrequire('lazy_set.js').LazySet;
 

frontend_tests/node_tests/compose_actions.js

@@ -13,7 +13,6 @@ set_global('$', global.make_zjquery());
 set_global('compose_pm_pill', {
 });
 
-set_global('i18n', global.stub_i18n);
 
 set_global('hash_util', {
 });

frontend_tests/node_tests/compose_fade.js

@@ -1,5 +1,4 @@
 set_global('blueslip', {});
-set_global('i18n', global.stub_i18n);
 global.blueslip.warn = function () {};
 
 zrequire('stream_data');

frontend_tests/node_tests/compose_ui.js

@@ -7,7 +7,6 @@ set_global('document', {
 });
 
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 set_global('blueslip', {});
 
 const alice = {

frontend_tests/node_tests/composebox_typeahead.js

@@ -1,5 +1,4 @@
 const typeahead = zrequire('typeahead', 'shared/js/typeahead');
-set_global('i18n', global.stub_i18n);
 zrequire('compose_state');
 zrequire('pm_conversations');
 zrequire('emoji');

frontend_tests/node_tests/drafts.js

@@ -1,5 +1,4 @@
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 
 zrequire('localstorage');
 zrequire('drafts');

frontend_tests/node_tests/filter.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('unread');
 zrequire('stream_data');

frontend_tests/node_tests/general.js

@@ -59,10 +59,8 @@ const denmark_stream = {
 // prefer to test with a clean slate.
 
 set_global('page_params', {});
-set_global('i18n', global.stub_i18n);
 
 zrequire('stream_data');
-set_global('i18n', global.stub_i18n);
 
 run_test('stream_data', () => {
     assert.equal(stream_data.get_sub_by_name('Denmark'), undefined);

frontend_tests/node_tests/hash_util.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('hash_util');
 zrequire('stream_data');

frontend_tests/node_tests/hashchange.js

@@ -5,7 +5,6 @@ set_global('location', {
     host: 'example.com',
 });
 set_global('to_$', () => window_stub);
-set_global('i18n', global.stub_i18n);
 
 zrequire('people');
 zrequire('hash_util');

frontend_tests/node_tests/i18n.js

@@ -1,6 +1,8 @@
 set_global('Handlebars', global.make_handlebars());
 zrequire('templates');
 
+// All of our other tests stub out i18n activity;
+// here we do a quick sanity check on the engine itself.
 const i18next = zrequire('i18next', 'i18next');
 
 global.i18n = i18next;

frontend_tests/node_tests/input_pill.js

@@ -1,5 +1,4 @@
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 zrequire('input_pill');
 
 set_global('Handlebars', global.make_handlebars());

frontend_tests/node_tests/markdown.js

@@ -1,7 +1,6 @@
 zrequire('hash_util');
 set_global('katex', zrequire('katex', 'katex/dist/katex.min.js'));
 set_global('marked', zrequire('marked', 'third/marked/lib/marked'));
-set_global('i18n', global.stub_i18n);
 
 zrequire('fenced_code');
 zrequire('stream_data');

frontend_tests/node_tests/message_list.js

@@ -15,7 +15,6 @@ zrequire('MessageListData', 'js/message_list_data');
 zrequire('MessageListView', 'js/message_list_view');
 const MessageList = zrequire('message_list').MessageList;
 
-set_global('i18n', global.stub_i18n);
 
 const with_overrides = global.with_overrides; // make lint happy
 

frontend_tests/node_tests/muting.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('muting');
 zrequire('stream_data');

frontend_tests/node_tests/narrow.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 set_global('$', global.make_zjquery());
 zrequire('hash_util');
 zrequire('hashchange');
@@ -6,7 +5,6 @@ zrequire('narrow_state');
 zrequire('people');
 zrequire('stream_data');
 zrequire('Filter', 'js/filter');
-set_global('i18n', global.stub_i18n);
 set_global('page_params', {
     stop_words: ['what', 'about'],
 });

frontend_tests/node_tests/narrow_activate.js

@@ -1,5 +1,4 @@
 const util = zrequire('util');
-set_global('i18n', global.stub_i18n);
 set_global('$', global.make_zjquery());
 
 zrequire('narrow_state');

frontend_tests/node_tests/narrow_local.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('Filter', 'js/filter');
 zrequire('MessageListData', 'js/message_list_data');

frontend_tests/node_tests/narrow_state.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('people');
 zrequire('Filter', 'js/filter');

frontend_tests/node_tests/narrow_unread.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('Filter', 'js/filter');
 zrequire('people');

frontend_tests/node_tests/notifications.js

@@ -20,7 +20,6 @@ const _navigator = {
 };
 set_global('navigator', _navigator);
 
-set_global('i18n', global.stub_i18n);
 
 zrequire('alert_words');
 zrequire('muting');

frontend_tests/node_tests/password.js

@@ -1,7 +1,6 @@
 set_global('zxcvbn', zrequire('zxcvbn', 'zxcvbn'));
 zrequire('common');
 
-set_global('i18n', global.stub_i18n);
 
 run_test('basics', () => {
     let accepted;

frontend_tests/node_tests/people.js

@@ -7,7 +7,6 @@ set_global('settings_org', {});
 set_global('md5', function (s) {
     return 'md5-' + s;
 });
-set_global('i18n', global.stub_i18n);
 
 const me = {
     email: 'me@example.com',

frontend_tests/node_tests/poll_widget.js

@@ -1,7 +1,6 @@
 zrequire('poll_widget');
 
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 
 set_global('people', {});
 set_global('blueslip', global.make_zblueslip());

frontend_tests/node_tests/popovers.js

@@ -1,5 +1,4 @@
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 
 zrequire('hash_util');
 zrequire('narrow');

frontend_tests/node_tests/search_suggestion.js

@@ -6,7 +6,6 @@ set_global('message_store', {
     user_ids: () => [],
 });
 
-set_global('i18n', global.stub_i18n);
 
 zrequire('typeahead_helper');
 set_global('Handlebars', global.make_handlebars());

frontend_tests/node_tests/search_suggestion_legacy.js

@@ -5,7 +5,6 @@ set_global('message_store', {
     user_ids: () => [],
 });
 
-set_global('i18n', global.stub_i18n);
 
 zrequire('typeahead_helper');
 set_global('Handlebars', global.make_handlebars());

frontend_tests/node_tests/settings_bots.js

@@ -19,7 +19,6 @@ const bot_data_params = {
 set_global("avatar", {});
 
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 
 zrequire('bot_data');
 zrequire('settings_bots');

frontend_tests/node_tests/settings_muting.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 set_global('$', global.make_zjquery());
 
 zrequire('settings_muting');

frontend_tests/node_tests/settings_org.js

@@ -1,5 +1,4 @@
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 set_global('blueslip', global.make_zblueslip());
 
 const noop = () => {};

frontend_tests/node_tests/settings_user_groups.js

@@ -2,7 +2,6 @@ zrequire('user_pill');
 zrequire('settings_user_groups');
 
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 set_global('confirm_dialog', {});
 
 const noop = function () {};

frontend_tests/node_tests/stream_data.js

@@ -9,7 +9,6 @@ set_global('$', function () {
 
 set_global('blueslip', global.make_zblueslip());
 set_global('document', null);
-set_global('i18n', global.stub_i18n);
 global.stub_out_jquery();
 
 zrequire('color_data');

frontend_tests/node_tests/stream_events.js

@@ -2,7 +2,6 @@ const noop = function () {};
 const return_true = function () { return true; };
 set_global('$', global.make_zjquery());
 set_global('document', 'document-stub');
-set_global('i18n', global.stub_i18n);
 
 zrequire('people');
 zrequire('stream_data');

frontend_tests/node_tests/stream_list.js

@@ -1,7 +1,6 @@
 set_global('document', 'document-stub');
 set_global('$', global.make_zjquery());
 set_global('blueslip', global.make_zblueslip());
-set_global('i18n', global.stub_i18n);
 
 zrequire('unread_ui');
 zrequire('Filter', 'js/filter');
@@ -17,7 +16,6 @@ zrequire('list_cursor');
 zrequire('stream_list');
 zrequire('topic_zoom');
 zrequire('ui');
-set_global('i18n', global.stub_i18n);
 set_global('page_params', {
     is_admin: false,
     realm_users: [],

frontend_tests/node_tests/stream_sort.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('stream_data');
 zrequire('stream_sort');

frontend_tests/node_tests/subs.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 global.stub_out_jquery();
 
 set_global('ui', {

frontend_tests/node_tests/timerender.js

@@ -1,5 +1,4 @@
 set_global('$', global.make_zjquery());
-set_global('i18n', global.stub_i18n);
 set_global('page_params', {
     twenty_four_hour_time: true,
 });

frontend_tests/node_tests/topic_data.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('unread');
 zrequire('stream_data');

frontend_tests/node_tests/topic_generator.js

@@ -2,7 +2,6 @@ set_global('blueslip', global.make_zblueslip());
 set_global('pm_conversations', {
     recent: {},
 });
-set_global('i18n', global.stub_i18n);
 
 zrequire('muting');
 zrequire('unread');

frontend_tests/node_tests/topic_list_data.js

@@ -2,7 +2,6 @@ set_global('narrow_state', {});
 set_global('unread', {});
 set_global('muting', {});
 set_global('message_list', {});
-set_global('i18n', global.stub_i18n);
 
 zrequire('hash_util');
 zrequire('stream_data');

frontend_tests/node_tests/typeahead_helper.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 set_global('page_params', {realm_is_zephyr_mirror_realm: false});
 set_global('md5', function (s) {
     return 'md5-' + s;

frontend_tests/node_tests/ui.js

@@ -1,5 +1,4 @@
 const ui = zrequire('ui');
-set_global('i18n', global.stub_i18n);
 
 set_global('navigator', {
     userAgent: '',

frontend_tests/node_tests/ui_init.js

@@ -21,7 +21,6 @@ const rewiremock = require("rewiremock/node");
 
 */
 const util = zrequire('util');
-set_global('i18n', global.stub_i18n);
 set_global('document', {
     location: {
         protocol: 'http',

frontend_tests/node_tests/unread.js

@@ -1,4 +1,3 @@
-set_global('i18n', global.stub_i18n);
 
 zrequire('muting');
 zrequire('people');

frontend_tests/node_tests/upload.js

@@ -7,7 +7,6 @@ set_global('document', {
 set_global('navigator', {
     userAgent: 'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)',
 });
-set_global('i18n', global.stub_i18n);
 set_global('page_params', {
     max_file_upload_size: 25,
 });

frontend_tests/zjsunit/index.js

@@ -53,7 +53,7 @@ global.make_zjquery = require('./zjquery.js').make_zjquery;
 global.make_zblueslip = require('./zblueslip.js').make_zblueslip;
 
 // Set up fake translation
-global.stub_i18n = require('./i18n.js');
+const stub_i18n = require('./i18n.js');
 
 // Set up Handlebars
 const handlebars = require('./handlebars.js');
@@ -113,6 +113,7 @@ try {
         _.throttle = immediate;
         _.debounce = immediate;
 
+        set_global('i18n', stub_i18n);
         namespace.clear_zulip_refs();
         run_one_module(file);
         namespace.restore();