paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

change_email_modal: Remove duplicate id attribute.

Browse Source 
This also naturally fixes the bug where the change_email_modal wouldn't
show the old email in the input box.
This commit is contained in:
Ganesh Pawar
2021-07-18 22:34:06 +05:30
committed by Tim Abbott
parent 45799f1f1d
commit b9aed2df19
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/settings_account.js
View File

@@ -29,7 +29,7 @@ import * as user_profile from "./user_profile";
let password_quality; // Loaded asynchronously let password_quality; // Loaded asynchronously
export function update_email(new_email) { export function update_email(new_email) {
const email_input = $("#email_value"); const email_input = $("#change_email");
if (email_input) { if (email_input) {
email_input.text(new_email); email_input.text(new_email);
@@ -523,7 +523,7 @@ export function set_up() {
e.stopPropagation(); e.stopPropagation();
if (!page_params.realm_email_changes_disabled || page_params.is_admin) { if (!page_params.realm_email_changes_disabled || page_params.is_admin) {
overlays.open_modal("#change_email_modal"); overlays.open_modal("#change_email_modal");
const email = $("#email_value").text().trim(); const email = $("#change_email").text().trim();
$(".email_change_container").find("input[name='email']").val(email); $(".email_change_container").find("input[name='email']").val(email);
} }
}); });

2
static/templates/settings/account_settings.hbs
View File

@@ -8,7 +8,7 @@
<div class="alert-notification" id="account-settings-status"></div> <div class="alert-notification" id="account-settings-status"></div>
<div class="input-group"> <div class="input-group">
<label class="inline-block title">{{t "Email" }}</label> <label class="inline-block title">{{t "Email" }}</label>
<button id='change_email' type="button" class="button btn-link small rounded inline-block" id='email_value' <button id='change_email' type="button" class="button btn-link small rounded inline-block"
{{#if (and page_params.realm_email_changes_disabled (not page_params.is_admin))}}disabled="disabled"{{/if}}> {{#if (and page_params.realm_email_changes_disabled (not page_params.is_admin))}}disabled="disabled"{{/if}}>
{{page_params.delivery_email}} {{page_params.delivery_email}}
<i class="fa fa-pencil"></i> <i class="fa fa-pencil"></i>