paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 03:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

actions: Remove some unnecessary log_event calls.

Browse Source 
Users editing messages or updating message flags are either already
recorded or not interesting from an audit perspective, and so there's
no need to use log_event with them.
This commit is contained in:
Tim Abbott
2017-04-06 14:14:25 -07:00
parent 6d27dcc801
commit b9c6c22b60
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/lib/actions.py
View File

@@ -2537,7 +2537,6 @@ def do_update_message_flags(user_profile, operation, flag, messages, all, stream
'flag': flag, 'flag': flag,
'messages': messages, 'messages': messages,
'all': all} 'all': all}
log_event(event)
send_event(event, [user_profile.id]) send_event(event, [user_profile.id])
statsd.incr("flags.%s.%s" % (flag, operation), count) statsd.incr("flags.%s.%s" % (flag, operation), count)
@@ -2638,7 +2637,6 @@ def do_update_embedded_data(user_profile, message, content, rendered_content):
event["content"] = content event["content"] = content
event["rendered_content"] = rendered_content event["rendered_content"] = rendered_content
log_event(event)
message.save(update_fields=["content", "rendered_content"]) message.save(update_fields=["content", "rendered_content"])
event['message_ids'] = update_to_dict_cache(changed_messages) event['message_ids'] = update_to_dict_cache(changed_messages)
@@ -2749,7 +2747,6 @@ def do_update_message(user_profile, message, subject, propagate_mode, content, r
edit_history = [edit_history_event] edit_history = [edit_history_event]
message.edit_history = ujson.dumps(edit_history) message.edit_history = ujson.dumps(edit_history)
log_event(event)
message.save(update_fields=["subject", "content", "rendered_content", message.save(update_fields=["subject", "content", "rendered_content",
"rendered_content_version", "last_edit_time", "rendered_content_version", "last_edit_time",
"edit_history"]) "edit_history"])