paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 00:23:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

testing: 100% coverage for zerver/tests/test_digest.py.

Browse Source
This commit is contained in:
Adam Sah
2022-05-18 05:14:15 -04:00
committed by Tim Abbott
parent 30457ecd02
commit ba5cf331a2
2 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/test-backend
View File

@@ -89,7 +89,6 @@ not_yet_fully_covered = [
"zerver/lib/bot_lib.py", "zerver/lib/bot_lib.py",
"zerver/lib/camo.py", "zerver/lib/camo.py",
"zerver/lib/debug.py", "zerver/lib/debug.py",
"zerver/lib/digest.py",
"zerver/lib/error_notify.py", "zerver/lib/error_notify.py",
"zerver/lib/export.py", "zerver/lib/export.py",
"zerver/lib/fix_unreads.py", "zerver/lib/fix_unreads.py",

30
zerver/tests/test_digest.py
View File

@@ -8,6 +8,7 @@ from django.utils.timezone import now as timezone_now
from confirmation.models import one_click_unsubscribe_link from confirmation.models import one_click_unsubscribe_link
from zerver.actions.create_user import do_create_user from zerver.actions.create_user import do_create_user
from zerver.actions.realm_settings import do_set_realm_property
from zerver.actions.users import do_deactivate_user from zerver.actions.users import do_deactivate_user
from zerver.lib.digest import ( from zerver.lib.digest import (
DigestTopic, DigestTopic,
@@ -159,6 +160,14 @@ class TestDigestEmailMessages(ZulipTestCase):
new_stream_names = kwargs["context"]["new_streams"]["plain"] new_stream_names = kwargs["context"]["new_streams"]["plain"]
self.assertTrue("web_public_stream" in new_stream_names) self.assertTrue("web_public_stream" in new_stream_names)
def test_no_logging(self) -> None:
hamlet = self.example_user("hamlet")
startlen = len(RealmAuditLog.objects.all())
bulk_write_realm_audit_logs([])
self.assert_length(RealmAuditLog.objects.all(), startlen)
bulk_write_realm_audit_logs([hamlet])
self.assert_length(RealmAuditLog.objects.all(), startlen + 1)
def test_soft_deactivated_user_multiple_stream_senders(self) -> None: def test_soft_deactivated_user_multiple_stream_senders(self) -> None:
one_day_ago = timezone_now() - datetime.timedelta(days=1) one_day_ago = timezone_now() - datetime.timedelta(days=1)
Message.objects.all().update(date_sent=one_day_ago) Message.objects.all().update(date_sent=one_day_ago)
@@ -325,6 +334,27 @@ class TestDigestEmailMessages(ZulipTestCase):
self.assertEqual(queue_mock.call_count, 0) self.assertEqual(queue_mock.call_count, 0)
@override_settings(SEND_DIGEST_EMAILS=True)
@override_settings(SYSTEM_ONLY_REALMS=["zulipinternal"])
def test_enqueue_emails(self) -> None:
# code coverage - digest.should_process_digest()
def call_enqueue_emails(realm: Realm) -> int:
do_set_realm_property(realm, "digest_emails_enabled", True, acting_user=None)
do_set_realm_property(
realm, "digest_weekday", timezone_now().weekday(), acting_user=None
)
cutoff = timezone_now() - datetime.timedelta(days=0)
with mock.patch(
"zerver.worker.queue_processors.bulk_handle_digest_email"
) as queue_mock:
enqueue_emails(cutoff)
return 0 if queue_mock.call_args is None else len(queue_mock.call_args[0][0])
num_queued_users = call_enqueue_emails(get_realm("zulipinternal"))
self.assertEqual(num_queued_users, 0)
num_queued_users = call_enqueue_emails(get_realm("zulip"))
self.assertEqual(num_queued_users, 10)
@override_settings(SEND_DIGEST_EMAILS=True) @override_settings(SEND_DIGEST_EMAILS=True)
def test_inactive_users_queued_for_digest(self) -> None: def test_inactive_users_queued_for_digest(self) -> None:
UserActivityInterval.objects.all().delete() UserActivityInterval.objects.all().delete()