paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: Slightly optimize content editing logic.

Browse Source 
Previously, we were searching the whole message_row object for emoji,
mentions, etc., which has a bunch of UI elements that can't contain
the syntax we want to modify.  This should be a slight improvement in
the performance of message post-processing, which runs a lot of times
and thus is fairly important.
This commit is contained in:
Tim Abbott
2018-12-18 14:48:07 -08:00
parent c2ced75d5a
commit ba77303ee4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/message_list_view.js
View File

@@ -462,7 +462,7 @@ MessageListView.prototype = {
content.addClass('rtl');
}
row.find('.user-mention').each(function () {
content.find('.user-mention').each(function () {
var user_id = get_user_id_for_mention_button(this);
// We give special highlights to the mention buttons
// that refer to the current user.
@@ -479,7 +479,7 @@ MessageListView.prototype = {
}
});
row.find('.user-group-mention').each(function () {
content.find('.user-group-mention').each(function () {
var user_group_id = get_user_group_id_for_mention_button(this);
var my_user_id = people.my_current_user_id();
// Mark user group you're a member of.
@@ -494,7 +494,7 @@ MessageListView.prototype = {
}
});
row.find('a.stream').each(function () {
content.find('a.stream').each(function () {
var stream_id = $(this).attr('data-stream-id');
if (stream_id && !$(this).find(".highlight").length) {
// Display the current name for stream if it is not
@@ -506,7 +506,7 @@ MessageListView.prototype = {
// Display emoji (including realm emoji) as text if
// page_params.emojiset is 'text'.
if (page_params.emojiset === 'text') {
row.find(".emoji").replaceWith(function () {
content.find(".emoji").replaceWith(function () {
var text = $(this).attr("title");
return ":" + text + ":";
});