diff --git a/frontend_tests/casper_tests/08-edit.js b/frontend_tests/casper_tests/08-edit.js index 1c29dfbaed..76f80ee529 100644 --- a/frontend_tests/casper_tests/08-edit.js +++ b/frontend_tests/casper_tests/08-edit.js @@ -94,8 +94,8 @@ casper.then(function () { casper.test.assertNotVisible('form.message_edit_form', 'Message edit box not visible'); common.keypress(37); - casper.waitUntilVisible("#message_edit_content", function () { - var fieldVal = common.get_form_field_value('#message_edit_content'); + casper.waitUntilVisible(".message_edit_content", function () { + var fieldVal = common.get_form_field_value('.message_edit_content'); casper.test.assertEquals(fieldVal, "test edited pm", "Opened editing last own message"); casper.click('.message_edit_cancel'); }); diff --git a/static/js/message_edit.js b/static/js/message_edit.js index 0ec8a6d8c0..f9e4b0d573 100644 --- a/static/js/message_edit.js +++ b/static/js/message_edit.js @@ -183,6 +183,7 @@ function edit_message(row, raw_content) { var form = $(templates.render( 'message_edit_form', {is_stream: (message.type === 'stream'), + message_id: message.id, is_editable: is_editable, has_been_editable: (editability !== editability_types.NO), topic: message.subject, @@ -220,9 +221,10 @@ function edit_message(row, raw_content) { initClipboard(copy_message[0]); } else if (editability === editability_types.FULL) { copy_message.remove(); - var listeners = resize.watch_manual_resize("#message_edit_content"); + var edit_id = "#message_edit_content_" + rows.id(row); + var listeners = resize.watch_manual_resize(edit_id); currently_editing_messages[rows.id(row)].listeners = listeners; - composebox_typeahead.initialize_compose_typeahead("#message_edit_content", {emoji: true, stream: true}); + composebox_typeahead.initialize_compose_typeahead(edit_id, {emoji: true, stream: true}); } // Add tooltip @@ -364,7 +366,7 @@ exports.end = function (row) { // Clean up resize event listeners var listeners = currently_editing_messages[message.id].listeners; - var edit_box = document.querySelector("#message_edit_content"); + var edit_box = document.querySelector("#message_edit_content_" + message.id); edit_box.removeEventListener("mousedown", listeners[0]); document.body.removeEventListener("mouseup", listeners[1]); diff --git a/static/js/ui_init.js b/static/js/ui_init.js index 5d7a2afd69..7cb1844363 100644 --- a/static/js/ui_init.js +++ b/static/js/ui_init.js @@ -214,11 +214,11 @@ $(function () { $('.copy_message[data-toggle="tooltip"]').tooltip(); - $("body").on("mouseover", "#message_edit_content", function () { + $("body").on("mouseover", ".message_edit_content", function () { $(this).closest(".message_row").find(".copy_message").show(); }); - $("body").on("mouseout", "#message_edit_content", function () { + $("body").on("mouseout", ".message_edit_content", function () { $(this).closest(".message_row").find(".copy_message").hide(); }); diff --git a/static/templates/message_edit_form.handlebars b/static/templates/message_edit_form.handlebars index 80171cec8f..32f5ade94d 100644 --- a/static/templates/message_edit_form.handlebars +++ b/static/templates/message_edit_form.handlebars @@ -16,13 +16,13 @@ {{/if}}