paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

stats: Remove unchecked casts of Plotly data.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2023-10-24 17:30:19 -07:00
committed by Tim Abbott
parent a145a6adfa
commit ba895b64ef
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
web/src/stats/stats.ts
View File

@@ -554,9 +554,12 @@ function populate_messages_sent_over_time(raw_data: unknown): void {
const plotDiv = document.querySelector<Plotly.PlotlyHTMLElement>( const plotDiv = document.querySelector<Plotly.PlotlyHTMLElement>(
"#id_messages_sent_over_time", "#id_messages_sent_over_time",
)!; )!;
traces.me.visible = (plotDiv.data[0] as Plotly.PlotData).visible; assert("visible" in plotDiv.data[0]);
traces.human.visible = (plotDiv.data[1] as Plotly.PlotData).visible; assert("visible" in plotDiv.data[1]);
traces.bot.visible = (plotDiv.data[2] as Plotly.PlotData).visible; assert("visible" in plotDiv.data[2]);
traces.me.visible = plotDiv.data[0].visible;
traces.human.visible = plotDiv.data[1].visible;
traces.bot.visible = plotDiv.data[2].visible;
} }
layout.xaxis!.rangeselector = rangeselector; layout.xaxis!.rangeselector = rangeselector;
if (clicked_cumulative || initial_draw) { if (clicked_cumulative || initial_draw) {
@@ -693,6 +696,9 @@ function populate_messages_sent_by_client(raw_data: unknown): void {
} }
type PlotDataByMessageClient = PlotTrace & { type PlotDataByMessageClient = PlotTrace & {
trace: {
x: number[];
};
trace_annotations: Partial<Plotly.PlotData>; trace_annotations: Partial<Plotly.PlotData>;
}; };
@@ -806,8 +812,8 @@ function populate_messages_sent_by_client(raw_data: unknown): void {
function draw_plot(): void { function draw_plot(): void {
$("#id_messages_sent_by_client > div").removeClass("spinner"); $("#id_messages_sent_by_client > div").removeClass("spinner");
const data_ = plot_data[user_button][time_button]; const data_ = plot_data[user_button][time_button];
layout.height = layout.margin!.b! + data_.trace.x!.length * 30; layout.height = layout.margin!.b! + data_.trace.x.length * 30;
layout.xaxis!.range = [0, Math.max(...(data_.trace.x as number[])) * 1.3]; layout.xaxis!.range = [0, Math.max(...data_.trace.x) * 1.3];
void Plotly.newPlot( void Plotly.newPlot(
"id_messages_sent_by_client", "id_messages_sent_by_client",
[data_.trace, data_.trace_annotations], [data_.trace, data_.trace_annotations],
@@ -1300,8 +1306,10 @@ function populate_messages_read_over_time(raw_data: unknown): void {
const plotDiv = document.querySelector<Plotly.PlotlyHTMLElement>( const plotDiv = document.querySelector<Plotly.PlotlyHTMLElement>(
"#id_messages_read_over_time", "#id_messages_read_over_time",
)!; )!;
traces.me.visible = (plotDiv.data[0] as Plotly.PlotData).visible; assert("visible" in plotDiv.data[0]);
traces.everyone.visible = (plotDiv.data[1] as Plotly.PlotData).visible; assert("visible" in plotDiv.data[1]);
traces.me.visible = plotDiv.data[0].visible;
traces.everyone.visible = plotDiv.data[1].visible;
} }
layout.xaxis!.rangeselector = rangeselector; layout.xaxis!.rangeselector = rangeselector;
if (clicked_cumulative || initial_draw) { if (clicked_cumulative || initial_draw) {