typing: Add appropriate none-checks for LOCAL_UPLOADS_DIR.

This is a part of django-stubs refactorings.

Signed-off-by: Zixuan James Li <359101898@qq.com>

zerver/lib/test_helpers.py

@@ -217,6 +217,7 @@ def avatar_disk_path(
 ) -> str:
     avatar_url_path = avatar_url(user_profile, medium)
     assert avatar_url_path is not None
+    assert settings.LOCAL_UPLOADS_DIR is not None
     avatar_disk_path = os.path.join(
         settings.LOCAL_UPLOADS_DIR,
         "avatars",

zerver/lib/test_runner.py

@@ -236,6 +236,7 @@ def init_worker(counter: "multiprocessing.sharedctypes.Synchronized[int]") -> No
     # We manually update the upload directory path in the URL regex.
     from zproject.dev_urls import avatars_url
 
+    assert settings.LOCAL_UPLOADS_DIR is not None
     new_root = os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars")
     avatars_url.default_args["document_root"] = new_root
 

zerver/lib/transfer.py

@@ -23,6 +23,7 @@ def transfer_uploads_to_s3(processes: int) -> None:
 
 def _transfer_avatar_to_s3(user: UserProfile) -> None:
     avatar_path = user_avatar_path(user)
+    assert settings.LOCAL_UPLOADS_DIR is not None
     file_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars", avatar_path) + ".original"
     try:
         with open(file_path, "rb") as f:
@@ -46,6 +47,7 @@ def transfer_avatars_to_s3(processes: int) -> None:
 
 
 def _transfer_message_files_to_s3(attachment: Attachment) -> None:
+    assert settings.LOCAL_UPLOADS_DIR is not None
     file_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "files", attachment.path_id)
     try:
         with open(file_path, "rb") as f:
@@ -82,6 +84,7 @@ def _transfer_emoji_to_s3(realm_emoji: RealmEmoji) -> None:
         realm_id=realm_emoji.realm.id,
         emoji_file_name=realm_emoji.file_name,
     )
+    assert settings.LOCAL_UPLOADS_DIR is not None
     emoji_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars", emoji_path) + ".original"
     try:
         with open(emoji_path, "rb") as f:

zerver/migrations/0149_realm_emoji_drop_unique_constraint.py

@@ -50,6 +50,7 @@ class LocalUploader(Uploader):
             os.makedirs(dirname)
 
     def copy_files(self, src_path: str, dst_path: str) -> None:
+        assert settings.LOCAL_UPLOADS_DIR is not None
         src_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars", src_path)
         self.mkdirs(src_path)
         dst_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars", dst_path)

zerver/tests/test_import_export.py

@@ -1177,6 +1177,7 @@ class RealmImportExportTest(ExportFile):
         uploaded_file = Attachment.objects.get(realm=imported_realm)
         self.assert_length(b"zulip!", uploaded_file.size)
 
+        assert settings.LOCAL_UPLOADS_DIR is not None
         attachment_file_path = os.path.join(
             settings.LOCAL_UPLOADS_DIR, "files", uploaded_file.path_id
         )

zerver/tests/test_upload.py

@@ -1762,6 +1762,7 @@ class LocalStorageTest(UploadSerializeMixin, ZulipTestCase):
         base = "/user_uploads/"
         self.assertEqual(base, uri[: len(base)])
         path_id = re.sub("/user_uploads/", "", uri)
+        assert settings.LOCAL_UPLOADS_DIR is not None
         file_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "files", path_id)
         self.assertTrue(os.path.isfile(file_path))
 
@@ -1800,6 +1801,7 @@ class LocalStorageTest(UploadSerializeMixin, ZulipTestCase):
 
         write_local_file("avatars", file_path + ".original", read_test_image_file("img.png"))
 
+        assert settings.LOCAL_UPLOADS_DIR is not None
         image_path = os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars", file_path + ".original")
         with open(image_path, "rb") as f:
             image_data = f.read()
@@ -1878,10 +1880,12 @@ class LocalStorageTest(UploadSerializeMixin, ZulipTestCase):
         user_profile = self.example_user("iago")
         self.assertTrue(user_profile.is_realm_admin)
 
+        assert settings.TEST_WORKER_DIR is not None
         tarball_path = os.path.join(settings.TEST_WORKER_DIR, "tarball.tar.gz")
         with open(tarball_path, "w") as f:
             f.write("dummy")
 
+        assert settings.LOCAL_UPLOADS_DIR is not None
         uri = upload_export_tarball(user_profile.realm, tarball_path)
         self.assertTrue(
             os.path.isfile(os.path.join(settings.LOCAL_UPLOADS_DIR, "avatars", tarball_path))