paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

events: Remove recipient_id from delete_message event.

Browse Source 
Remove `recipient_id` from `delete_message` event response
when `message_type` is `private`. API changelog updated in
next commit.
This commit is contained in:
Gaurav Pandey
2021-06-12 01:45:19 +05:30
committed by Tim Abbott
parent ec7dc08e11
commit bc131c1636
4 changed files with 1 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
zerver/lib/events.py
View File

@@ -987,23 +987,6 @@ def apply_event(
if "raw_recent_private_conversations" not in state or event["message_type"] != "private":
return
recipient_id = get_recent_conversations_recipient_id(
user_profile, event["recipient_id"], event["sender_id"]
)
# Ideally, we'd have test coverage for these two blocks. To
# do that, we'll need a test where we delete not-the-latest
# messages or delete a private message not in
# recent_private_conversations.
if recipient_id not in state["raw_recent_private_conversations"]: # nocoverage
return
old_max_message_id = state["raw_recent_private_conversations"][recipient_id][
"max_message_id"
]
if old_max_message_id not in message_ids: # nocoverage
return
# OK, we just deleted what had been the max_message_id for
# this recent conversation; we need to recompute that value
# from scratch. Definitely don't need to re-query everything,