paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

reactions: Add back missing e.stopPropagation().

Browse Source 
In 42f20e81be I fixed an edge case but
also accidentally made clicking on reactions open the compose box.

This commit adds back the e.stopPropagation(); and explicitly hides the
emoji picker popover, to address the inconsistency fixed in the previous
commit.
This commit is contained in:
Gittenburg
2020-07-14 09:08:16 +02:00
committed by Tim Abbott
parent 75cfd886b7
commit bc1f2fa80e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/click_handlers.js
View File

@@ -170,7 +170,9 @@ exports.initialize = function () {
message_flags.toggle_starred_and_update_server(message);
});
$("#main_div").on("click", ".message_reaction", function () {
$("#main_div").on("click", ".message_reaction", function (e) {
e.stopPropagation();
emoji_picker.hide_emoji_popover();
const local_id = $(this).attr('data-reaction-id');
const message_id = rows.get_message_id(this);
reactions.process_reaction_click(message_id, local_id);