paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom_profile_fields: Remove op field for the event.

Browse Source 
* `op` (operation) field, added in f6fb88549f, was never intended for
`custom_profile_fields` event. This commit removes the `op` as it doesn't
have any use in the code.

* As a part of cleanup, this also eliminates the schema check warnings
for `custom_profile_fields` event, mentioned in #17568.
This commit is contained in:
shanukun
2021-03-26 14:21:43 +05:30
committed by Tim Abbott
parent 79586cc466
commit bc2d58ad4a
8 changed files with 37 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
zerver/tests/test_events.py
View File

@@ -65,6 +65,7 @@ from zerver.lib.actions import (
do_remove_default_stream,
do_remove_default_stream_group,
do_remove_reaction,
do_remove_realm_custom_profile_field,
do_remove_realm_domain,
do_remove_realm_emoji,
do_remove_realm_filter,
@@ -92,6 +93,7 @@ from zerver.lib.actions import (
lookup_default_stream_groups,
notify_realm_custom_profile_fields,
remove_members_from_user_group,
try_add_realm_custom_profile_field,
try_update_realm_custom_profile_field,
)
from zerver.lib.event_schema import (
@@ -165,6 +167,7 @@ from zerver.lib.test_helpers import (
from zerver.lib.topic import TOPIC_NAME
from zerver.models import (
Attachment,
CustomProfileField,
Message,
MultiuseInvite,
PreregistrationUser,
@@ -694,20 +697,32 @@ class NormalActionsTest(BaseAction):
check_typing_stop("events[0]", events[0])
def test_custom_profile_fields_events(self) -> None:
realm = self.user_profile.realm
try_add_realm_custom_profile_field(
realm=realm, name="Expertise", field_type=CustomProfileField.LONG_TEXT
)
events = self.verify_action(
lambda: notify_realm_custom_profile_fields(self.user_profile.realm, "add"),
lambda: notify_realm_custom_profile_fields(self.user_profile.realm),
state_change_expected=False,
)
check_custom_profile_fields("events[0]", events[0])
realm = self.user_profile.realm
field = realm.customprofilefield_set.get(realm=realm, name="Biography")
name = field.name
hint = "Biography of the user"
try_update_realm_custom_profile_field(realm, field, name, hint=hint)
events = self.verify_action(
lambda: notify_realm_custom_profile_fields(self.user_profile.realm, "add"),
lambda: notify_realm_custom_profile_fields(self.user_profile.realm),
state_change_expected=False,
)
check_custom_profile_fields("events[0]", events[0])
do_remove_realm_custom_profile_field(realm, field)
events = self.verify_action(
lambda: notify_realm_custom_profile_fields(self.user_profile.realm),
state_change_expected=False,
)
check_custom_profile_fields("events[0]", events[0])