paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

server_events_dispatch: Throw from "subscription" based on event.op.

Browse Source
This commit is contained in:
YashRE42
2020-06-20 19:14:09 +00:00
committed by Tim Abbott
parent d89c405074
commit bc69521caa
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend_tests/node_tests/dispatch.js
View File

@@ -5,6 +5,7 @@ const {strict: assert} = require("assert");
const {mock_cjs, mock_esm, set_global, with_field, zrequire} = require("../zjsunit/namespace"); const {mock_cjs, mock_esm, set_global, with_field, zrequire} = require("../zjsunit/namespace");
const {make_stub} = require("../zjsunit/stub"); const {make_stub} = require("../zjsunit/stub");
const {run_test} = require("../zjsunit/test"); const {run_test} = require("../zjsunit/test");
const blueslip = require("../zjsunit/zblueslip");
const $ = require("../zjsunit/zjquery"); const $ = require("../zjsunit/zjquery");
const noop = () => {}; const noop = () => {};
@@ -875,3 +876,8 @@ run_test("realm_export", (override) => {
const args = stub.get_args("exports"); const args = stub.get_args("exports");
assert.equal(args.exports, event.exports); assert.equal(args.exports, event.exports);
}); });
run_test("server_event_dispatch_op_errors", () => {
blueslip.expect("error", "Unexpected event type subscription/other");
server_events_dispatch.dispatch_normal_event({type: "subscription", op: "other"});
});

3
static/js/server_events_dispatch.js
View File

@@ -471,6 +471,9 @@ export function dispatch_normal_event(event) {
case "update": case "update":
stream_events.update_property(event.stream_id, event.property, event.value); stream_events.update_property(event.stream_id, event.property, event.value);
break; break;
default:
blueslip.error("Unexpected event type subscription/" + event.op);
break;
} }
break; break;
case "typing": case "typing":