paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Move dev-only templates to templates/zerver/development.

Browse Source 
This a prep commit for adding a check to lint to ensure
only development-related templates entrypoint name
starts with `dev`.
This commit is contained in:
Riken Shah
2021-04-16 15:37:13 +00:00
committed by Tim Abbott
parent e27268837b
commit bd9e6ae97e
9 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/linter_lib/custom_check.py
View File

@@ -635,7 +635,10 @@ html_rules: List["Rule"] = [
"description": "Don't use inline event handlers (onclick=, etc. attributes) in HTML. Instead,"
"attach a jQuery event handler ($('#foo').on('click', function () {...})) when "
"the DOM is ready (inside a $(function () {...}) block).",
"exclude": {"templates/zerver/dev_login.html", "templates/corporate/upgrade.html"},
"exclude": {
"templates/zerver/development/dev_login.html",
"templates/corporate/upgrade.html",
},
"good_lines": ["($('#foo').on('click', function () {}"],
"bad_lines": [
"<button id='foo' onclick='myFunction()'>Foo</button>",
@@ -661,7 +664,7 @@ html_rules: List["Rule"] = [
"templates/zerver/emails/email_base_messages.html",
# Email log templates; should clean up.
"templates/zerver/email.html",
"templates/zerver/email_log.html",
"templates/zerver/development/email_log.html",
# Social backend logos are dynamically loaded
"templates/zerver/accounts_home.html",
"templates/zerver/login.html",