paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Add linter rule banning $.get and friends.

Browse Source 
These are not allowed in our style guide.
This commit is contained in:
Tim Abbott
2018-02-13 16:47:09 -08:00
parent a19a69bfe3
commit be3d43bb46
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/contributing/code-style.md
View File

@@ -217,7 +217,7 @@ code a lot uglier, in which case it's fine to go up to 120 or so.
When calling a function with an anonymous function as an argument, use When calling a function with an anonymous function as an argument, use
this style: this style:
$.get('foo', function (data) { my_function('foo', function (data) {
var x = ...; var x = ...;
// ... // ...
}); });

12
tools/linter_lib/custom_check.py
View File

@@ -230,6 +230,18 @@ def build_custom_checkers(by_lang):
'description': "`Use $(f) rather than `$(document).ready(f)`", 'description': "`Use $(f) rather than `$(document).ready(f)`",
'good_lines': ['$(function () {foo();}'], 'good_lines': ['$(function () {foo();}'],
'bad_lines': ['$(document).ready(function () {foo();}']}, 'bad_lines': ['$(document).ready(function () {foo();}']},
{'pattern': '[$][.](get|post|patch|delete|ajax)[(]',
'description': "Use channel module for AJAX calls",
'exclude': set([
# Internal modules can do direct network calls
'static/js/blueslip.js',
'static/js/channel.js',
# External modules that don't include channel.js
'static/js/stats/',
'static/js/portico/',
]),
'good_lines': ['channel.get(...)'],
'bad_lines': ['$.get()', '$.post()', '$.ajax()']},
{'pattern': 'style ?=', {'pattern': 'style ?=',
'description': "Avoid using the `style=` attribute; we prefer styling in CSS files", 'description': "Avoid using the `style=` attribute; we prefer styling in CSS files",
'exclude': set([ 'exclude': set([