paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

pep8: Add compliance with rule E261 tools/js-dep-visualizer.py.

Browse Source
This commit is contained in:
Aditya Bansal
2017-06-01 00:55:04 +05:30
committed by Tim Abbott
parent 807fee68d6
commit be66369b72
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/js-dep-visualizer.py
View File

@@ -33,11 +33,11 @@ OUTPUT_FILE_PATH = os.path.relpath(os.path.join(ROOT_DIR, 'var/zulip-deps.dot'))
def get_js_edges(): def get_js_edges():
# type: () -> Tuple[EdgeSet, MethodDict] # type: () -> Tuple[EdgeSet, MethodDict]
names = set() names = set()
modules = [] # type: List[Dict[str, Any]] modules = [] # type: List[Dict[str, Any]]
for js_file in os.listdir(JS_FILES_DIR): for js_file in os.listdir(JS_FILES_DIR):
if not js_file.endswith('.js'): if not js_file.endswith('.js'):
continue continue
name = js_file[:-3] # remove .js name = js_file[:-3] # remove .js
path = os.path.join(JS_FILES_DIR, js_file) path = os.path.join(JS_FILES_DIR, js_file)
names.add(name) names.add(name)
modules.append(dict( modules.append(dict(
@@ -49,7 +49,7 @@ def get_js_edges():
comment_regex = re.compile('\s+//') comment_regex = re.compile('\s+//')
call_regex = re.compile('[^_](\w+\.\w+)\(') call_regex = re.compile('[^_](\w+\.\w+)\(')
methods = defaultdict(list) # type: DefaultDict[Edge, List[Method]] methods = defaultdict(list) # type: DefaultDict[Edge, List[Method]]
edges = set() edges = set()
for module in modules: for module in modules:
parent = module['name'] parent = module['name']
@@ -144,7 +144,7 @@ def find_edges_to_remove(graph, methods):
('stream_edit', 'stream_list'), ('stream_edit', 'stream_list'),
('reactions', 'emoji_picker'), ('reactions', 'emoji_picker'),
('message_edit', 'resize'), ('message_edit', 'resize'),
] # type: List[Edge] ] # type: List[Edge]
def is_exempt(edge): def is_exempt(edge):
# type: (Tuple[str, str]) -> bool # type: (Tuple[str, str]) -> bool
@@ -260,8 +260,8 @@ def find_edges_to_remove(graph, methods):
def report_roadmap(edges, methods): def report_roadmap(edges, methods):
# type: (List[Edge], MethodDict) -> None # type: (List[Edge], MethodDict) -> None
child_modules = {child for parent, child in edges} child_modules = {child for parent, child in edges}
module_methods = defaultdict(set) # type: DefaultDict[str, Set[str]] module_methods = defaultdict(set) # type: DefaultDict[str, Set[str]]
callers = defaultdict(set) # type: DefaultDict[Tuple[str, str], Set[str]] callers = defaultdict(set) # type: DefaultDict[Tuple[str, str], Set[str]]
for parent, child in edges: for parent, child in edges:
for method in methods[(parent, child)]: for method in methods[(parent, child)]:
module_methods[child].add(method) module_methods[child].add(method)