From be7a70e7425246a5ee86d1d4e663a8228109ec9d Mon Sep 17 00:00:00 2001 From: m-e-l-u-h-a-n Date: Wed, 28 Oct 2020 15:02:49 +0530 Subject: [PATCH] logging: Remove unnecessary mock.patch() for logging. Our test-backend validation confirms that we don't log anything to stdout in the tests, so the fact that CI passes with this removes shows there was nothing being logged. --- zerver/tests/test_email_log.py | 3 +-- zerver/tests/test_user_groups.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/zerver/tests/test_email_log.py b/zerver/tests/test_email_log.py index b21f9fcb66..ee90bbc9d1 100644 --- a/zerver/tests/test_email_log.py +++ b/zerver/tests/test_email_log.py @@ -32,8 +32,7 @@ class EmailLogTest(ZulipTestCase): self.assertEqual(get_forward_address(), forward_address) - with self.settings(EMAIL_BACKEND='zproject.email_backends.EmailLogBackEnd'), \ - mock.patch('logging.info', return_value=None): + with self.settings(EMAIL_BACKEND='zproject.email_backends.EmailLogBackEnd'): with mock.patch('zproject.email_backends.EmailLogBackEnd.send_email_smtp'): result = self.client_get('/emails/generate/') self.assertEqual(result.status_code, 302) diff --git a/zerver/tests/test_user_groups.py b/zerver/tests/test_user_groups.py index 24ed19a7c7..409fc28952 100644 --- a/zerver/tests/test_user_groups.py +++ b/zerver/tests/test_user_groups.py @@ -422,8 +422,7 @@ class UserGroupAPITestCase(ZulipTestCase): content=content_with_group_mention, ) - with mock.patch('logging.info'): - result = self.api_post(sender, "/json/messages", payload) + result = self.api_post(sender, "/json/messages", payload) self.assert_json_success(result)