paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 07:52:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only call add_message_metadata once when receiving messages in a narrowed view

Browse Source 
We memoize add_message_metadata by checking if the message is already
in the all_msg_list.  Therefore, we need to add messages to that
message list before we add it to the narrowed_msg_list.

(imported from commit 4346179376ef6f982162c02c6152a0d294bfb2c0)
This commit is contained in:
Zev Benjamin
2013-05-03 14:04:30 -04:00
committed by Tim Abbott
parent 96129b1cf0
commit beba14a86c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zephyr/static/js/zephyr.js
View File

@@ -826,6 +826,9 @@ function get_updates(options) {
// should no longer be needed // should no longer be needed
messages = deduplicate_messages(messages); messages = deduplicate_messages(messages);
add_messages(messages, all_msg_list);
add_messages(messages, home_msg_list);
if (narrow.active()) { if (narrow.active()) {
if (narrow.filter().can_apply_locally()) { if (narrow.filter().can_apply_locally()) {
add_messages(messages, narrowed_msg_list); add_messages(messages, narrowed_msg_list);
@@ -833,8 +836,7 @@ function get_updates(options) {
maybe_add_narrowed_messages(messages, narrowed_msg_list); maybe_add_narrowed_messages(messages, narrowed_msg_list);
} }
} }
add_messages(messages, all_msg_list);
add_messages(messages, home_msg_list);
process_visible_unread_messages(); process_visible_unread_messages();
notifications.received_messages(messages); notifications.received_messages(messages);
compose.update_faded_messages(); compose.update_faded_messages();