paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

input-pill: Disable input of commas with invalid pills.

Browse Source 
A user should not be able to start forming a new pill if the previous
pill is invalid.
This commit is contained in:
Brock Whittaker
2017-11-13 13:07:49 -08:00
committed by Tim Abbott
parent 4cd25fb861
commit bee0fa4001
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
static/js/input_pill.js
View File

@@ -6,6 +6,7 @@ var input_pill = function ($parent) {
BACKSPACE: 8,
LEFT_ARROW: 37,
RIGHT_ARROW: 39,
COMMA: 188,
};
// a stateful object of this `pill_container` instance.
@@ -303,6 +304,21 @@ var input_pill = function ($parent) {
store.$parent.find(".pill").last().focus();
}
}
// users should not be able to type a comma if the last field doesn't
// validate.
if (char === KEY.COMMA) {
// if the pill is successful, it will create the pill and clear
// the input.
if (funcs.appendPill(store.$input.text().trim()) !== false) {
funcs.clear(store.$input[0]);
// otherwise it will prevent the typing of the comma because they
// cannot add another pill until this input is valid.
} else {
e.preventDefault();
return;
}
}
});
// handle events while hovering on ".pill" elements.