paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

notifications: Remove unused fields in queue events.

Browse Source 
* `stream_name`: This field is actually redundant. The email/push
  notifications handlers don't use that field from the dict, and they
  anyways query for the message, so we're safe in deleting this field,
  even if in the future we end up needing the stream name.

* `timestamp`: This is totally unused by the email/push notification
  handlers, and aren't sent to push clients either.

* `type` is used only for the push notifications handler, since only
  push notifications can be revoked, so we move them to only run there.
This commit is contained in:
Abhijeet Prasad Bodas
2021-07-08 11:00:40 +05:30
committed by Tim Abbott
parent 76dc504f7e
commit bf15c0235a
4 changed files with 1 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/lib/test_classes.py
View File

@@ -1363,7 +1363,6 @@ Output:
message_id=message_id,
acting_user_id=acting_user_id,
private_message=kwargs.get("private_message", False),
stream_name=kwargs.get("stream_name", None),
mentioned_user_group_id=kwargs.get("mentioned_user_group_id", None),
idle=kwargs.get("idle", True),
already_notified=kwargs.get(