From bf1c5e08ecb991680090e9b3b53c9c338340e2a8 Mon Sep 17 00:00:00 2001
From: Sayam Samal <sayam@zulip.com>
Date: Wed, 9 Apr 2025 01:38:25 +0530
Subject: [PATCH] tests: Fix admin.test.ts failing puppeteer test using
 waitForFunction.

(cherry picked from commit f7129ae5505aebb7be4ed1e0a3da1f1cb914b56b)
---
 web/e2e-tests/admin.test.ts | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/web/e2e-tests/admin.test.ts b/web/e2e-tests/admin.test.ts
index cc153708f5..470002bc41 100644
--- a/web/e2e-tests/admin.test.ts
+++ b/web/e2e-tests/admin.test.ts
@@ -10,17 +10,26 @@ async function submit_announcements_stream_settings(page: Page): Promise<void> {
     });
 
     const save_button = "#org-notifications .save-button";
-    const button_text = await common.get_text_from_selector(page, save_button);
-    assert.strictEqual(button_text, "Save changes", "Save button has incorrect text.");
+    await page.waitForFunction(
+        (save_button: string) => {
+            const button = document.querySelector(save_button);
+            return button && button.textContent?.trim() === "Save changes";
+        },
+        {},
+        save_button,
+    );
     await page.click(save_button);
 
     await page.waitForSelector('#org-notifications .save-button[data-status="saved"]', {
         visible: true,
     });
-    assert.strictEqual(
-        await common.get_text_from_selector(page, "#org-notifications .save-button"),
-        "Saved",
-        "Saved text didn't appear after saving new stream notifications setting",
+    await page.waitForFunction(
+        (save_button: string) => {
+            const button = document.querySelector(save_button);
+            return button && button.textContent?.trim() === "Saved";
+        },
+        {},
+        save_button,
     );
 
     await page.waitForSelector("#org-notifications .save-button", {hidden: true});