paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

popovers: Add confirmation modal for marking all messages as read.

Browse Source 
This commit adds a confirmation modal with loading spinner for
marking all messages as read.

New file: confirm_mark_all_as_read.hbs
Fixes: #24624
This commit is contained in:
Palash Baderia
2022-10-11 17:50:27 +05:30
committed by Tim Abbott
parent ba0dd70904
commit bf51277226
3 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/stream_popover.js
View File

@@ -680,8 +680,8 @@ export function register_stream_handlers() {
// Mark all messages as read // Mark all messages as read
$("body").on("click", "#mark_all_messages_as_read", (e) => { $("body").on("click", "#mark_all_messages_as_read", (e) => {
hide_all_messages_popover(); hide_all_messages_popover();
unread_ops.mark_all_as_read();
e.stopPropagation(); e.stopPropagation();
unread_ops.confirm_mark_all_as_read();
}); });
// Unstar all messages // Unstar all messages

17
web/src/unread_ops.js
View File

@@ -1,7 +1,11 @@
import $ from "jquery"; import $ from "jquery";
import render_confirm_mark_all_as_read from "../templates/confirm_dialog/confirm_mark_all_as_read.hbs";
import * as blueslip from "./blueslip"; import * as blueslip from "./blueslip";
import * as channel from "./channel"; import * as channel from "./channel";
import * as confirm_dialog from "./confirm_dialog";
import * as dialog_widget from "./dialog_widget";
import {$t_html} from "./i18n"; import {$t_html} from "./i18n";
import * as loading from "./loading"; import * as loading from "./loading";
import * as message_flags from "./message_flags"; import * as message_flags from "./message_flags";
@@ -27,6 +31,17 @@ let loading_indicator_displayed = false;
const INITIAL_BATCH_SIZE = 1000; const INITIAL_BATCH_SIZE = 1000;
const FOLLOWUP_BATCH_SIZE = 1000; const FOLLOWUP_BATCH_SIZE = 1000;
export function confirm_mark_all_as_read() {
const html_body = render_confirm_mark_all_as_read();
confirm_dialog.launch({
html_heading: $t_html({defaultMessage: "Mark all messages as read?"}),
html_body,
on_click: mark_all_as_read,
loading_spinner: true,
});
}
export function mark_all_as_read(args = {}) { export function mark_all_as_read(args = {}) {
args = { args = {
// We use an anchor of "oldest", not "first_unread", because // We use an anchor of "oldest", not "first_unread", because
@@ -116,6 +131,7 @@ export function mark_all_as_read(args = {}) {
blueslip.log("Cleared old_unreads_missing after bankruptcy."); blueslip.log("Cleared old_unreads_missing after bankruptcy.");
} }
} }
dialog_widget.close_modal();
}, },
error(xhr) { error(xhr) {
// If we hit the rate limit, just continue without showing any error. // If we hit the rate limit, just continue without showing any error.
@@ -127,6 +143,7 @@ export function mark_all_as_read(args = {}) {
// the user needs to know that our operation failed. // the user needs to know that our operation failed.
blueslip.error("Failed to mark messages as read: " + xhr.responseText); blueslip.error("Failed to mark messages as read: " + xhr.responseText);
} }
dialog_widget.hide_dialog_spinner();
}, },
}); });
} }

5
web/templates/confirm_dialog/confirm_mark_all_as_read.hbs Normal file
View File

@@ -0,0 +1,5 @@
<p>
{{#tr}}
Are you sure you want to mark all messages as read? This action cannot be undone.
{{/tr}}
</p>